Given an array nums, write a function to move all 0's to the end of it while maintaining the relative order of the non-zero elements

Question

0.00/5 (No votes)

See more:

Given an array nums, write a function to move all 0's to the end of it while maintaining the relative order of the non-zero elements

.
Example:

Input: [0,1,0,3,12]
Output: [1,3,12,0,0]

What I have tried:

class Solution {
public:
    void moveZeroes(vector<int>& nums) {
        int count=0;
        for(int i=0;i<nums.size();i++)
        {
            if(nums[i]==0)
            {
                nums.erase(nums.begin()+i);
                ++count; //This is to count number of zeroes.
            }
        }
       for(int i=0;i<count;i++)
       
           nums.push_back(0);  //To input zero at the end of the vector count times.
       
}
};

This code shows the correct output for the input :

[0,1,0,3,12]

but wrong output for input:

[0,0,1]

.
For input,

[0,0,1]

it shows

[0,1,0]

. It should be

[1,0,0]

Posted 5-Jul-18 7:33am

Regista6

Updated 5-Jul-18 8:13am

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2018-07-05T08:13:00

Your problem is that this

C++

nums.erase(nums.begin()+i);

moves remaining values in vector.
try this to see what is going on

C++

for(int i=0;i<nums.size();i++)
{
    if(nums[i]==0)
    {
        nums.erase(nums.begin()+i);
        ++count; //This is to count number of zeroes.
    }
    else
    {
        // add 100 to each nont zero tested
        nums[i]+=100
    }
}

-----
Your code do not behave the way you expect, and you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.
Debugger - Wikipedia, the free encyclopedia[^]
1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]
The debugger is here to only show you what your code is doing and your task is to compare with what it should do.