"Some 50 line co code "" lines of code are same in two different if else condition ho w to manage

Question

0.00/5 (No votes)

See more:

if(xyz==1)
{
if(searchFilter.FormId == 0 || SubTab.AppType == searchFilter.FormId)
{
	Some 50 Line co code 
}	
}

else (searchFilter.FormId == 0 || SubTab.AppType == searchFilter.FormId || (SubTab.AppType == (int)_partner.Form.Homeless) && searchFilter.FormId != null)
{
		Some 50 Line co code 
}

Note : both "Some 50 Line co code "" lines of code are same , so can I do this in another way to not repeat same code, what should have to do for the same,

What I have tried:

<pre>if(xyz==1)
{
if(searchFilter.FormId == 0 || SubTab.AppType == searchFilter.FormId)
{
	Some 50 Line co code 
}	
}

else (searchFilter.FormId == 0 || SubTab.AppType == searchFilter.FormId || (SubTab.AppType == (int)_partner.Form.Homeless) && searchFilter.FormId != null)
{
		Some 50 Line co code 
}

Note : both "Some 50 Line co code "" lines of code are same , so can I do this in another way to not repeat same code, what should have to do for the same,

Posted 2-Jul-18 20:10pm

kumarravishankar

Updated 2-Jul-18 21:53pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mehdi Gholam · Answer 1 · 2018-07-02T20:15:00

Solution 1

The way to consolidate code is to create a method/function and put the duplicate code in it and call it from the the duplicate places.

Posted 2-Jul-18 20:15pm

Mehdi Gholam

Comments

Maciej Los 3-Jul-18 3:51am

Short And To The Point!
5!

Maciej Los · Answer 2 · 2018-07-02T21:53:00

Solution 2

In addition to Mehdi Gholam[^]'s answer, i'd like to provide a link to MSDN documentation: Methods (C# Programming Guide) | Microsoft Docs[^], which explains how to create method.

Posted 2-Jul-18 21:53pm

Maciej Los