How do I keep adding two strings into vectors using while loop in C++

Question

0.00/5 (No votes)

See more:

Hello, I am writing a code that allows users to add a certain movie's name with its director and then display what the user wrote. I am using vectors but the code that I tried only displays the values after I write the first name and director's name. Moreover, after the two initial inputs the strings are not put together. Any help on keep adding values to the vector then displaying? The code below is a constructor Movie().

What I have tried:

Movie() {
		cout << "Enter the film name name: " << endl;
		getline(cin, filmname);
		cout << "Enter the director's name: " << endl;
		getline(cin, director);
		full = filmname + " " + director;
		cout << "The film and director is therefore: " << full << endl;
		while (cin >> full) {
			if (full == "end") {
				break;
			}
			Film.push_back(full);
		}
		cout << "You entered the following: ";
		for (int i = 0; i < Film.size(); i++) {
			cout << Music[i] << endl;
		}
	}

Posted 7-May-18 13:33pm

Member 13816159

Updated 7-May-18 21:23pm

User 7429338

v2

Add a Solution

Comments

Patrice T 8-May-18 2:18am

Show an autonomous piece of code, so that we can reproduce the problem.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

User 7429338 · Answer 1 · 2018-05-07T20:21:00

Solution 1

With cin >> full you are overwriting the current value of full with the new input.
You should store the new input in a separate string and append to full until "end" is typed.

Posted 7-May-18 20:21pm

User 7429338

Comments

KarstenK 8-May-18 3:26am

Another Q&A which the importance of the usage of the debugger shows :-O

Richard MacCutchan · Answer 2 · 2018-05-07T21:24:00

The while statement should be at the beginning of the block, before you get the film details, and a do loop would probably work better:

C++

do
{
    cout << "Enter the film name name: " << endl;
    getline(cin, filmname);
    if (filmname == "end")
        break;
    cout << "Enter the director's name: " << endl;
    getline(cin, director);
    full = filmname + " " + director;
    cout << "The film and director is therefore: " << full << endl;
    Film.push_back(full);
} while (true);