Replacing a value in an array

Question

0.00/5 (No votes)

See more:

I'm trying to replace the min value in an array in the max value, I have an issue with the output.

the output:

after replace = 5 
after replace = 6 
after replace = 7 
after replace = 7 
after replace = 7 
after replace = 3

it should be:
4
5
6
7
7
3

What I have tried:

int main( void )
{
struct str
{
   int  arr[6];   
};

struct str select =
{    
    { 4, 5, 6, 7,1,3 }
};
struct tt{
int a[1];
};
struct tt t;

for (int i=0;i<6;i++){
printf("arr = %d \n",select.arr[i]);
}

int min=select.arr[0];
int max=select.arr[0];
for (int i = 0; i < 6; i++) {
           
        if (select.arr[i] > max){
            max=select.arr[i];
            t.a[i]=max;}
         else if (select.arr[i] < min){
            min = select.arr[i];
            select.arr[i]=max;}
    }

printf("min = %d     max =%d \n",min,max);
for (int i=0;i<6;i++){
printf("after replace = %d \n",select.arr[i]);
}
}

Posted 27-Apr-18 23:51pm

Lilyanaa

Updated 28-Apr-18 3:24am

v2

Add a Solution

Comments

Patrice T 28-Apr-18 6:19am

"I'm trying to replace the min value in an array in the max value"
Not clear !
Show actual output and expected output.
Explain what is wrong in output.

Richard MacCutchan 28-Apr-18 8:01am

Why are you using struct types, when all you need is simple arrays?

Lilyanaa 28-Apr-18 8:50am

I have other members in my program, but this simple description of the issue

Richard MacCutchan 28-Apr-18 9:08am

I am still unsure what your real problem is.

Lilyanaa 28-Apr-18 9:14am

the output of this code is after replace = 5
after replace = 6
after replace = 7
after replace = 7
after replace = 7
after replace = 3 ,
it shuld be{4 5 6 7 7 3}, what is the problen in this code?

Richard MacCutchan 28-Apr-18 9:28am

You need two loops.
1. Iterate the array, find and save the minimum value and the maximum value.
2. Iterate the array, if the array item equals the minimum value, replace it with the maximum.

Lilyanaa 28-Apr-18 10:04am

I do it thank u so much

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-04-28T00:24:00

How big is the array a in the tt struct?
How many elements of that array do you use?

That isn't your problem, but it's a "future problem" that you need to take care of.

As far as I can see, your code does what you describe it as "should be doing":

C++

arr = 4 
arr = 5 
arr = 6 
arr = 7 
arr = 1 
arr = 3 
min = 1     max =7 
after replace = 4 
after replace = 5 
after replace = 6 
after replace = 7 
after replace = 7 
after replace = 3

Patrice T · Answer 2 · 2018-04-28T03:26:00

Quote:
I'm trying to replace the min value in an array in the max value, I have an issue with the output.

This is not what your code is doing.
Your code is replacing minimums while you are searching minimum and maximum.
Your code need to search minimum and maximum, and when they are known, replace the minimum.
Example input: { 4, 5, 6, 7, 1, 3, 1 } to handle multiple minimums.

Advice: Learn how to use the debugger.
Your code do not behave the way you expect, and you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.
Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
1.11 — Debugging your program (stepping and breakpoints) | Learn C++[^]
The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

Replacing a value in an array

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0