I am not getting any results while filtering database using datetimepicker, combobox, textbox.

Question

1.00/5 (1 vote)

See more:

Hi,

While i am using below code i am not getting any result.

I have,

Combobox - 1
Textbox - 1
Datetimepicker - 2

i have filter database using Comboboxselecteditem,textbox1.text and datetimepicker1 and datetimepicker2.

can anyone suggest me?

What I have tried:

Here is my code,

C#

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.Data.OleDb;
using System.Configuration;
using System.Data.SqlClient;

OleDbConnection con2 = new OleDbConnection(@"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=F:\Consoldetails.accdb");
private void button4_Click(object sender, EventArgs e)
{
   OleDbCommand command = new OleDbCommand();
   command.Connection = con2;
   string query = "select * from Finaldetails where (" + this.comboBox1.SelectedItem + ")  LIKE ('" + this.textBox1.Text + "') and  Date between '" + this.dateTimePicker1.Text + "' and '" + this.dateTimePicker2.Text + "' and Status = 'Approved'";

   command.CommandText = query;
   OleDbDataAdapter da = new OleDbDataAdapter(command);
   DataTable dt = new DataTable();
   da.Fill(dt);
   dataGridView1.DataSource = dt;
   con2.Close();
}

Posted 4-Apr-18 9:05am

Prateek gsharma

Updated 4-Apr-18 9:59am

Wendelius

v3

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2018-04-04T09:08:00

The main problem is that you're concatenating the data from UI objects directly to your SQL statement. This introduces conversion problems and leaves you open to SQL injections.

The correct way to do this is to use OleDbParameter Class (System.Data.OleDb)[^]

So the code should look something like

OleDbConnection con2 = new OleDbConnection(@"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=F:\Consoldetails.accdb");
private void button4_Click(object sender, EventArgs e)
{
   OleDbCommand command = new OleDbCommand();
   command.Connection = con2;
   string query = "select * from Finaldetails where (" + this.comboBox1.SelectedItem + ") LIKE (?) and Date between ? and ? and Status = 'Approved'";
   command.CommandText = query;
   command.Parameters.Add("@v1", OleDbType.VarChar, 100).Value = this.textBox1.Text;
   command.Parameters.Add("@v2", OleDbType.Date).Value = this.dateTimePicker1.Text;
   command.Parameters.Add("@v3", OleDbType.Date).Value = this.dateTimePicker2.Text;
   OleDbDataAdapter da = new OleDbDataAdapter(command);
   DataTable dt = new DataTable();
   da.Fill(dt);
   dataGridView1.DataSource = dt;
   con2.Close();
}

I do not know the actual data types so you have to adjust to code based on the requirements. Also I don't have a compiler at hand so sorry about any typos.

For more examples, have a look at Properly executing database operations[^]. Even though the example uses SqlParameters, the idea is the same

Patrice T · Accepted Answer · 2018-04-04T10:01:00

Make sure date format match dateTimePicker1 and dateTimePicker2 format. To compare dates in text, you must use yyyymmdd format.

C#

string query = "select * from Finaldetails where (" + this.comboBox1.SelectedItem + ")  LIKE ('" + this.textBox1.Text + "') and  Date between '" + this.dateTimePicker1.Text + "' and '" + this.dateTimePicker2.Text + "' and Status = 'Approved'";

Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]

I am not getting any results while filtering database using datetimepicker, combobox, textbox.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0