Want to use MVC pattern properly

Question

0.00/5 (No votes)

See more:

I have been coding for a few years and often end up with very busy Controllers and a few static helper methods. The code is stable and works fine, but can be a pain to comeback to after a few months and update. And I can't help but think I'm fighting with MVC rather then using it to its full potential.

I'm looking for a well written small open source c# MVC Project, that I can download and learn from. Ideally one that has Unit testing and uses Entity Framework.

So can anyone suggest a good project to learn from, or failing that a good book or online course?

What I have tried:

Looking at nopCommerce, but it is much to large.

Posted 28-Mar-18 1:54am

Member 8741848

Updated 28-Mar-18 2:46am

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2018-03-28T02:31:00

Solution 1

Try the Articles section here on CodeProject, or use Google to do a wider search.

Posted 28-Mar-18 2:31am

Richard MacCutchan

Comments

Member 8741848 28-Mar-18 8:49am

Do you have one (or some) that you can recommend? I've gotten myself in to this 'problem' by following poor/simple examples.

#realJSOP · Answer 2 · 2018-03-28T02:35:00

Solution 2

You can break your controller code into multiple files (you have to make your controller a partial class). I do this if the controllers are "busy". It helps to keep stuff compartmentalized a little more and you avoid having to scroll past methods that aren't applicable to what you're doing. I usually put non-decorated actions in the main file (stuff that doesn't have a get/post pair), and actions that DO have a get/post get their own file.

I also move my controller files to their respective view folders. This lets me find them without having to scroll to find the controllers folder and then find the controller file I want.

Of course, this kind of file organization may be restrained/prohibited by corporate coding style requirements, but I always do this for my own stuff.

Posted 28-Mar-18 2:35am

#realJSOP

Updated 28-Mar-18 2:38am

v4

Comments

F-ES Sitecore 28-Mar-18 8:44am

If your controllers are "busy" then rather than abusing partial classes you could always just move the business logic into the models where it's supposed to be :)

#realJSOP 28-Mar-18 9:32am

It doesn't always belong in the models (uploading files for instance). It's just an organizational scheme, since most of the time, I'm simply updating the model in my post statements. "Busy" also means moderately complex redirects based on data provided by the user, or which button cause the post method to be called. So you see, it's not as cut/dried as you imply.

Member 8741848 28-Mar-18 9:38am

I've had a few of these, where the controller is full dealing with various buttons even if the logic behind each on is rather simple. It's those types of things I would like to see in a open source project or book to see how I should have handled it.

#realJSOP 28-Mar-18 9:42am

My answer was simply to let you know that you can move the controller files around within the project and utilize partial classes, and as long as you don't change the namespace, you're gold. It sounds to me like you just want to organize the files a little more to your liking. If I made an incorrect assumption, just ignore me. :)

#realJSOP 28-Mar-18 9:39am

How is utilizing features of the framework considered "abuse"?

F-ES Sitecore 28-Mar-18 10:17am

Partial classes are generally used for auto-generated code to allow you to extend it without your changes being overridden the next time the auto-gen runs. Entity Framework and web forms make use of this for the code they generate.

#realJSOP 28-Mar-18 11:25am

I don't have any auto-generated code except for the template files that VS generates when I create a new UI class. I don't consider using partial files to be a bad way to organize large classes.

F-ES Sitecore 28-Mar-18 11:44am

> I don't have any auto-generated code

Exactly :)

Member 8741848 28-Mar-18 8:52am

From what I read here: https://softwareengineering.stackexchange.com/questions/135724/separating-data-access-in-asp-net-mvc it would be better to have a Business Service dealing with the controller logic. Is that what you are doing with your partial classes?

#realJSOP 28-Mar-18 9:36am

No. It's just a code organizational scheme and a way to make finding what I want in the code faster.

If you ask ten people how they write MVC apps, you'll get ten different answers. Take what appeals to you and add it to your own toolbox.

Another thing I do is try to minimize the amount of code in the outward facing cshtml files. I have static extension methods for most controls that package up the MVC controls in appropriate layouts. Instead of five-six lines of code in the cshtml file for a given control, I have just one.

Member 8741848 28-Mar-18 9:40am

very good point on the cshtml files, I haven't even started to look at improving those.

Dave Kreskowiak · Answer 3 · 2018-03-28T02:47:00

Solution 3

It also sounds like you've write a single monolithic controller handling everything. Reorganize the controller into multiple controllers handling a specific topic, like Login, Home page, ...

Posted 28-Mar-18 2:47am

Dave Kreskowiak

Comments

Member 8741848 28-Mar-18 8:59am

It's normally split that way for the majority of my controllers, but in most projects I will end up with one controller that seams to keep growing. e.g. If I were to write something for a car dealer, my car controller would end up stuffed full of loads of different actions related to the cars. Or just a few action but with lines & lines of code.
It just seams not right, and I would like to review some well written / organised projects to see where I'm going wrong. Or start from scratch with a good book / course.

#realJSOP 28-Mar-18 9:38am

It's a matter of personal organizational style. Remember, "best practice" isn't a hard/fast rule - it's just a guideline.