Issue with validation (presence check) using VB.NET

Question

0.00/5 (No votes)

See more:

I am using a total of 7 text boxes, six of them are named txtBox1,txtBox2,txtBox3,txtBox4,txtBox5,txtBox6, the seventh is named txtBoxSearch,I have tried using the code below to carry out a presence check, the problem is that I only want to carry out the presence check on the first 6 text boxes, the code below includes the txtBoxSearch as well. I don't know how to deal with this, does anyone have any ideas?Thanks.

What I have tried:

      Dim PresenceCheck As Boolean

 Dim emptyTextBoxes =
From txt In Me.Controls.OfType(Of TextBox)()
             Where txt.Text.Length = 0
         Select txt.Name()
        If emptyTextBoxes.Any Then

        End If
        PresenceCheck = False
        'this piece of code looks for all text boxes in the form, if any of them are blank their name would be included in the messagebox which reminds the user to fill them in'


        MessageBox.Show(String.Format("Please fill following textboxes: {0}",
                        String.Join(",", emptyTextBoxes)))
        MessageBox.Show("Customer has not been successfully added")

Posted 21-Mar-18 4:51am

faiqaa

Updated 21-Mar-18 6:39am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Accepted Answer · 2018-03-21T06:40:00

Solution 1

If you would like to get a list of TextBoxes, which name is txtBoxN (where N is a number) and TextBox is not empty, then try this:

VB.NET

Dim pattern As String = "^txtBox\d$"
Dim r As Regex = New Regex(pattern)

Dim notEmptyTextBoxes = Me.Controls.OfType(Of TextBox) _
                            .Where(Function(x) x.Text.Trim.Length > 0 And r.Match(x.Name).Success) _
                            .ToList()

For Each tb As TextBox In notEmptyTextBoxes
    MsgBox(String.Format("{0} {1}", tb.Name, tb.Text))
Next

If you would like to inform a user about textboxes to fill, try this:

VB.NET

Dim msg = String.Join("; ", Me.Controls.OfType(Of TextBox) _
                            .Where(Function(x) x.Text.Trim.Length = 0 And r.Match(x.Name).Success) _
                            .Select(Function(x) x.Name) _
                            .ToList())

MsgBox("Please, fill the following textboxes: " & vbCr & _
        msg, MsgBoxStyle.Information, "Information")

Posted 21-Mar-18 6:40am

Maciej Los

Updated 21-Mar-18 6:48am

v2

Comments

faiqaa 21-Mar-18 12:54pm

okay my fault, let me see whether is works now. Thanks. So basically I'm trying to save customer details and if the text boxes are empty I dont need to save the details
however if they are filled then I will need to.

Maciej Los 21-Mar-18 12:59pm

BTW: you can edit your comments. Move your mouse over it and on the right side you'll see a pencil. ;)

faiqaa 21-Mar-18 13:18pm

Hello, can you please have a look at this?, one thing that is happening is that when I've filled in all text boxes and press the button, I receive multiple message boxes showing me the information inputted in various text boxes and the last message box says" Please fill the following text boxes:"), this is happening even when they are filled in.

 Dim PresenceCheck As Boolean
        Dim pattern As String = "^txtBox\d$"
        Dim r As Regex = New Regex(pattern)

        Dim notEmptyTextBoxes = Me.Controls.OfType(Of TextBox) _
                                    .Where(Function(x) x.Text.Trim.Length > 0 And r.Match(x.Name).Success) _
                                    .ToList()

        For Each tb As TextBox In notEmptyTextBoxes
            MsgBox(String.Format("{0} {1}", tb.Name, tb.Text))
        Next
        Dim msg = String.Join("; ", Me.Controls.OfType(Of TextBox) _
                               .Where(Function(x) x.Text.Trim.Length = 0 And r.Match(x.Name).Success) _
                               .Select(Function(x) x.Name) _
                               .ToList())
        PresenceCheck = False
        MsgBox("Please, fill the following textboxes: " & vbCr & _
                msg, MsgBoxStyle.Information, "Information")

        If PresenceCheck = True Then
            Dim Filenum As Integer = FreeFile()
            FileOpen(Filenum, "C:\Users\Windows 7 User\Desktop\Customers.txt", OpenMode.Append) 'Text file is opened'

            PrintLine(Filenum, txtBox1.Text & "," & txtBox2.Text & "," & txtBox3.Text & "," & txtBox4.Text & "," & txtBox5.Text & "," & txtBox6.Text) 'The data entered in the above text boxes is combined together separated with commas and stored into the open text file'

            FileClose(Filenum) 'Once this is done the text file is closed and message below is displayed'

            MessageBox.Show("Customer has been successfully registered")
        End If

Maciej Los 21-Mar-18 13:38pm

Think about that!

        Dim pattern As String = "^txtBox\d$"
        Dim r As Regex = New Regex(pattern)
        Dim msg As String = String.Join("; ", Me.Controls.OfType(Of TextBox) _
                               .Where(Function(x) x.Text.Trim.Length = 0 And r.Match(x.Name).Success) _
                               .Select(Function(x) x.Name) _
                               .ToList())
        If msg<>"" Then MsgBox("Please, fill the following textboxes: " & vbCr & _
                    msg, MsgBoxStyle.Information, "Information")

        msg = String.Join(",", Me.Controls.OfType(Of TextBox) _
                                    .Where(Function(x) x.Text.Trim.Length > 0 And r.Match(x.Name).Success) _
                                    .Select(Function(x) String.Concat(x.Name, ":", x.Text)) _
                                    .ToList())
        If msg<>"" Then
            Dim Filenum As Integer = FreeFile()
            FileOpen(Filenum, "C:\Users\Windows 7 User\Desktop\Customers.txt", OpenMode.Append) 'Text file is opened'
            PrintLine(Filenum, msg) 'The data entered in the above text boxes is combined together separated with commas and stored into the open text file'
            FileClose(Filenum) 'Once this is done the text file is closed and message below is displayed'
            MessageBox.Show("Customer has been successfully registered")
        End If

faiqaa 21-Mar-18 13:46pm

now it says "overload resolution failed because no accessible 'Concat' can be called with these arguments".

Maciej Los 21-Mar-18 14:07pm

Check again.

faiqaa 21-Mar-18 14:11pm

Thank you so much sir, it's working just the way I needed it to work.

Maciej Los 21-Mar-18 14:14pm

Extra! Can you accept my answer as a solution (to remove your question from unanswered list)?

faiqaa 21-Mar-18 14:46pm

Sir, currently if all text boxes are empty then the details are not stored into the text file,however if I type in one of the text boxes and the others are empty then the details are still stored and this shouldn't happen since all text boxes must be filled in.

Maciej Los 21-Mar-18 14:52pm

Dear faiqaa, all you have to do is to change Where statement. There's no way to learn if you don't try to solve issue yourself.
You cannot expect that i resolve all your issues in one answer.

faiqaa 21-Mar-18 15:25pm

That's fine, if I look at both where statements they do seem to be fine, in the first the length must be equal to 0 and in the second one it needs to be bigger than 0 since I'm dealing with the filled in text boxes.

Maciej Los 21-Mar-18 15:40pm

You're going into right direction! Note: if the requirement is to fill out all textboxes, a [msg] variable (for the second time) should contain all textboxes data. In other words... data from empty textboxes aren't writen into text file (because there's no data).
I'm very happy that you've started to resolve issue yourself.
Good luck!
Cheers,
Maciej

faiqaa 21-Mar-18 16:26pm

Sir I'm trying my best in understanding what you said, since I had to also add a validation for the phone numbers I've done that,I'm still facing the same issue both validation fail the data should be saved which is currently happening, even if one text box is empty the data should not be saved and if the phone number is any lower than 9 or bigger than 11 then the same should happen.

The code that I have now is:

Dim pattern As String = "^txtBox\d$"
Dim r As Regex = New Regex(pattern)
Dim msg As String = String.Join("; ", Me.Controls.OfType(Of TextBox) _
.Where(Function(x) x.Text.Trim.Length = 0 And r.Match(x.Name).Success) _
.Select(Function(x) x.Name) _
.ToList())
If msg <> "" Then MsgBox("Please, fill the following textboxes: " & vbCr & _
msg, MsgBoxStyle.Information, "Information")

msg = String.Join(",", Me.Controls.OfType(Of TextBox) _
.Where(Function(x) x.Text.Trim.Length > 0 And r.Match(x.Name).Success) _
.Select(Function(x) String.Concat(x.Name, ":", x.Text)) _
.ToList())

If txtBox5.Text.Length < 9 Then
MsgBox("Phone numbers must be at least 9 digits long") ' if the value entered in text box 5 is < 9 then the respective message box would be shown'
txtBox5.Focus()
MessageBox.Show("Customer has not been successfully registered")
End If
If txtBox5.Text.Length > 11 Then
MsgBox("Phone numbers must be of a maximum of 11 digits long") ' if the value entered in text box 5 is > 11 then the respective message box would be shown'
txtBox5.Focus()
MessageBox.Show("Customer has not been successfully registered")
End If

If msg <> "" Then
Dim Filenum As Integer = FreeFile()
FileOpen(Filenum, "C:\Users\Windows 7 User\Desktop\Customers.txt", OpenMode.Append) 'Text file is opened'
PrintLine(Filenum, txtBox1.Text & "," & txtBox2.Text & "," & txtBox3.Text & "," & txtBox4.Text & "," & txtBox5.Text & "," & txtBox6.Text) 'The data entered in the above text boxes is combined together separated with commas and stored into the open text file'
FileClose(Filenum) 'Once this is done the text file is closed and message below is displayed'
MessageBox.Show("Customer has been successfully registered")
End If

Sir I do understand you want me to learn but right now I'm really desperate since I have a deadline for tomorrow,I've started to code from a few months. I really don't know what to do next.

kiswanimoh 10-Mar-22 15:24pm

d: \

Richard Deeming 21-Mar-18 17:12pm

NB: FreeFile / FileOpen / PrintLine / FileClose is the ancient VB6 way of writing to a file.

Since you're using .NET, you should consider using the .NET way of doing it:
How to: Write Text to a File | Microsoft Docs[^]
(The examples are in C#, but they're not too hard to translate.)

If PresenceCheck Then
    IO.File.AppendLine("C:\Users\Windows 7 User\Desktop\Customers.txt",
        txtBox1.Text & "," & txtBox2.Text & "," & txtBox3.Text & "," & txtBox4.Text & "," & txtBox5.Text & "," & txtBox6.Text)
End If

And if that's meant to be the current user's desktop path, you should use My.Computer.FileSystem.SpecialDirectories.Desktop[^] to retrieve it:

Dim folderPath As String = My.Computer.FileSystem.SpecialDirectories.Desktop
Dim filePath As String = IO.Path.Combine(folderPath, "Customers.txt")

faiqaa 21-Mar-18 17:19pm

Wait, have you responded to the main question at the top? or to the comments?

Richard Deeming 21-Mar-18 17:20pm

I'm replying to your comment.

faiqaa 21-Mar-18 17:27pm

But sir, you've written "If PresenceCheck" I have not used that in my code and I would need to declare it.

Richard Deeming 21-Mar-18 17:28pm

The comment I replied to has:

If PresenceCheck = True Then
    Dim Filenum As Integer = FreeFile()

If you didn't write that comment, who did?

faiqaa 21-Mar-18 17:31pm

oh yes I did, I thought you were talking about the last comment, sorry for misunderstanding.