Can someone please help me fix this C++ code?

Question

0.00/5 (No votes)

See more:

I am trying to program this, so that if the signature is "CCC" then output "No", else output "Yes"...
I get the following error:
nccc5j1.cpp: In function 'int main()':
nccc5j1.cpp:6:9: error: expected initializer before 'signatureNotAllowed'
signatureNotAllowed = "CCC";
^~~~~~~~~~~~~~~~~~~
nccc5j1.cpp:9:15: error: 'signatureNotAllowed' was not declared in this scope
If (input == signatureNotAllowed)
^~~~~~~~~~~~~~~~~~~
nccc5j1.cpp:9:34: error: 'If' was not declared in this scope
If (input == signatureNotAllowed)
^

What I have tried:

C++

#include <iostream>
using namespace std;

int main() {
	string signatureNotAllowed
        signatureNotAllowed = "CCC";
	    string input;
        cin >> input;
	If (input == signatureNotAllowed) 
		cout <<"No"<<endl;
	If (input != signatureNotAllowed) 
		cout << "Yes"<<endl;
	return 0;
}

Posted 12-Feb-18 22:47pm

RV2020

Updated 12-Feb-18 23:49pm

CPallini

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Accepted Answer · 2018-02-12T22:51:00

Solution 1

Either add a semicolon at then end of the signatureNotAllowed variable declaration:

C++

string signatureNotAllowed;
signatureNotAllowed = "CCC"s;

or declare and initialize the variable on the same line:

C++

string signatureNotAllowed = "CCC"s;

You also have to suffix the string with s to initialize a string variable; otherwise you have to declare it as a char*.

Posted 12-Feb-18 22:51pm

phil.o

Updated 12-Feb-18 22:56pm

v3

Comments

RV2020 13-Feb-18 5:30am

I corrected it to:
#include <iostream>
using namespace std;

int main() {
string signatureNotAllowed;
signatureNotAllowed = "CCC";
string input;
cin >> input;
if (input == signatureNotAllowed)
cout <<"No"<<endl;
If (input != signatureNotAllowed)
cout << "Yes"<<endl;
return 0;
}

But there is still an error message:
nccc5j1.cpp: In function 'int main()':
nccc5j1.cpp:11:34: error: 'If' was not declared in this scope
If (input != signatureNotAllowed)

-Thanks for your help by the way!

phil.o 13-Feb-18 5:36am

C++ is case sensitive, so if is a language statement, whereas If is unknown (and then considered as an undeclared variable).

CPallini 13-Feb-18 5:49am

5.

phil.o 13-Feb-18 6:19am

Thanks :)

Richard MacCutchan · Accepted Answer · 2018-02-12T23:33:00

Solution 2

You have also mis-spelled if, it uses a ower case i at the beginning. And you do not need the second if because you have already tested for equality, just use else for the second half, the same as you would in normal speech.

C++

if (input == signatureNotAllowed) 
    cout <<"No"<<endl;
else 
    cout << "Yes"<<endl;

Posted 12-Feb-18 23:33pm

Richard MacCutchan

Comments

CPallini 13-Feb-18 5:49am

5.

RV2020 13-Feb-18 5:53am

thanks!