How to fix listbox insert into database

Question

0.00/5 (No votes)

See more:

VS2013

I Mange to solve my problem earlier inserting a listbox items into database, but only the 1st item in the listbox is being inserted.

What I have tried:

This is my code:

VB

Try
          connect()
          connection.Open()
          Dim queryString As String
          queryString = "Insert into ServiceRecords([Personnel]) Values(@Personnels)"
          command = New OleDbCommand(queryString, connection)
          For i As Integer = 0 To Me.ListBox1.Items.Count + 1
              command.Parameters.AddWithValue("@Personnels", ListBox1.Items(i))
          Next
      Catch ex As Exception

      End Try

Posted 5-Feb-18 20:34pm

WinterPrison

Updated 5-Feb-18 22:16pm

Add a Solution

Comments

Maciej Los 6-Feb-18 3:01am

I doubt it, becase your command is never executed...
All what you need to do is to create command and execute it (using ExecuteNonQuery() method) inside a for-next loop.
Got it?

WinterPrison 6-Feb-18 3:18am

Tnx, but it didnt fix my problem.

Maciej Los 6-Feb-18 3:20am

Are you sure?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2018-02-05T22:16:00

Solution 1

Your loop is all wrong; you are adding every listbox item to the same parameter name. And you never execute any command so nothing will go to the database. Your loop needs to take each ListBox item in turn, add it to the parameter set as you are doing, and then use ExecutNonQuery (as Maciej already told you), to send the item to the database.

VB

queryString = "Insert into ServiceRecords([Personnel]) Values(@Personnels)"
command = New OleDbCommand(queryString, connection)
For i As Integer = 0 To Me.ListBox1.Items.Count + 1
    command.Parameters.AddWithValue("@Personnels", ListBox1.Items(i))
    command.ExecuteNonQuery()
    command.Parameters.Clear()
Next

See OleDbCommand.ExecuteNonQuery Method (System.Data.OleDb)[^].

Posted 5-Feb-18 22:16pm

Richard MacCutchan

Updated 5-Feb-18 22:52pm

v2

Comments

WinterPrison 6-Feb-18 4:39am

Sorry to ask this Richard i now get that ExecuteNonQuery() part, but how should i do the looping part

For i As Integer = 0 To Me.ListBox1.Items.Count + 1
    command.Parameters.AddWithValue("@Personnels", ListBox1.Items(i))
    command.ExecuteNonQuery()
Next

Richard MacCutchan 6-Feb-18 4:53am

See my updated code. You should study the documentation for all these methods as I may well be doing something wrong.

Maciej Los 6-Feb-18 4:48am

Richard, small note: a command should be created inside a for-next loop too due to increase of count of parameters in each step of loop.

Richard MacCutchan 6-Feb-18 4:50am

Thanks, I missed that bit. You can guess I am not an SQL programmer.

Maciej Los 6-Feb-18 4:53am

You're very welcome :)

WinterPrison 6-Feb-18 5:08am

Sorry to ask this again but do i need to put 2 command.ExecuteNonQuery()?

because...

i have another query here

 Try
            connect()
            connection.Open()
            Dim queryString As String
            queryString = "Insert into ServiceRecords([ServiceID],[ClientName],[Contact Person],[Address],[TimeStarted],[TimeEnded],[OpDate],[FloorDrain Quantity],[FloorDrain Clogged],[FloorDrain F/R]) Values(@SeriveID,@ClientName,[@Contact Person],@Address,@TimeStarted,@TimeEnded,@OpDate,[@FloorDrain Quantity],[@FloorDrain Clogged],[@FloorDrain F/R])"
            command = New OleDbCommand(queryString, connection)
            command.Parameters.Add(New OleDbParameter("ServiceID", CType(serviceIDText.Text, String)))
            command.Parameters.Add(New OleDbParameter("ClientName", CType(clientNameText.Text, String)))
            command.Parameters.Add(New OleDbParameter("Contact Person", CType(cPersonText.Text, String)))
            command.Parameters.Add(New OleDbParameter("Address", CType(addressText.Text, String)))
            command.Parameters.Add(New OleDbParameter("TimeStarted", CType(timeStartedText.Text, String)))
            command.Parameters.Add(New OleDbParameter("TimeEnded", CType(timeEndedText.Text, String)))
            command.Parameters.Add(New OleDbParameter("OpDate", CType(datePicker.Text, Date)))
            command.Parameters.Add(New OleDbParameter("FloorDrain Quantity", CType(fldQuantityText.Text, String)))
            command.Parameters.Add(New OleDbParameter("FloorDrain Clogged", CType(fldClcbox.CheckState, Boolean)))
            command.Parameters.Add(New OleDbParameter("FloorDrain F/R", CType(fldFinRecText.Text, String)))

            command.ExecuteNonQuery()
            insertListBox()

            MsgBox("Successfully Added!", MsgBoxStyle.Information)

and i am calling the fucntion insertListBox()

    Private Sub insertListBox()
       
        'This is code for listbox items to inserted to the database ew'


            Try

            Dim queryString As String
           queryString = "Insert into ServiceRecords([Personnel]) Values(@Personnels)"
            command = New OleDbCommand(queryString, connection)
            For i As Integer = 0 To Me.ListBox1.Items.Count + 1
                command.Parameters.AddWithValue("@Personnels", ListBox1.Items(i))
                command.ExecuteNonQuery()
                command.Parameters.Clear()
            Next

        Catch ex As Exception

        End Try


    End Sub

Richard MacCutchan 6-Feb-18 5:25am

Yes, each call to ExecuteNonQuery is related only to the current command that it is called on. You also need to check the return value each time to see if it succeeded. Do not display messages like "Successfully Added!" when you have no idea whether it succeeded or not.

WinterPrison 6-Feb-18 5:47am

Guys thanks for your help really it successfully inserted into database but, is it possible to insert it in one row in datagridview?

Richard MacCutchan 6-Feb-18 6:02am

Sorry, I don't understand the question.

WinterPrison 6-Feb-18 6:33am

This is my new problem.

https://i.stack.imgur.com/9G6JB.png

and im getting this

https://i.stack.imgur.com/Ucv50.png

Richard MacCutchan 6-Feb-18 8:54am

Sorry, but I have no idea what that is supposed to mean. If you have a different problem then please open a new question and provide proper details.