Proplem in my code pls help me? ! !

Question

1.44/5 (2 votes)

See more:

SQL-Server-2014

I want to read employee information from the employee table and check if the item is stored in the attendance table with the day, barcode and name entries before storing it in the database. When you create the following code, the data is stored twice at the same time.

What I have tried:

Dim command As SqlCommand
        command = New SqlCommand("SELECT COUNT(EmpName) as EmpNameCount FROM EmployeesAttend", con)
        Dim reader As SqlDataReader = command.ExecuteReader()
        '++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
        While (reader.Read())
            If reader("EmpNameCount") = 0 Then
                'حالة عدم وجود بيانات
                'حفظ البيانات مباشرة
                GetEmpInfo()
                SaveEmpInfATT()
                Clear()

            Else
                'حالة وجود بيانات
                ' التأكد من عدم وجود ازدواجية
                If con.State = ConnectionState.Open Then
                    con.Close()
                End If
                con = New SqlConnection(cs)
                con.Open()
                Dim cmd11 As New SqlCommand(" Select EmpCode from EmployeesAttend Where EmpCode = '" & TxtCode.Text.Trim & "' and AttendsDay='" & Label8.Text.Trim & "' and AttendsDate = '" & Label5.Text.Trim & "'  ", con)
                Dim dr1 As SqlDataReader = cmd11.ExecuteReader()
                '=================================
                If dr1.Read Then
                    If MsgBox(" الموظف  تم تسجيلة من قبل و لا يمكن تسجيلة مره اخرى", MsgBoxStyle.Exclamation, "منظومة الدمرداش المدرسية") = MsgBoxResult.Ok Then
                        con.Close()
                        TxtCode.SelectAll()
                        Exit Sub
                    End If
                Else
                    GetEmpInfo()
                    SaveEmpInfATT()
                    Clear()

                End If
                '=======================================
            End If
        End While

Posted 27-Jan-18 6:56am

Mr.Wessam Abdallah

Updated 27-Jan-18 8:22am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2018-01-27T08:22:00

VB

Dim cmd11 As New SqlCommand(" Select EmpCode from EmployeesAttend Where EmpCode = '" & TxtCode.Text.Trim & "' and AttendsDay='" & Label8.Text.Trim & "' and AttendsDate = '" & Label5.Text.Trim & "'  ", con)

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]