How to open a Google map by clicking on listview item?

Question

0.00/5 (No votes)

See more:

I need help from someone who knows how to use maps in Android Studio. I'm interested in how to open a G.Map by clicking on a listview item from Fragment.This is my code:

This is code from Fragment:

Java

@OnItemClick(R.id.lvTours)
    public void onItemClick(int position) {


        String tour = ((Tours) lvTours.getAdapter().getItem(position)).getCoord();//coordinats are stored on Firebase
        Intent showMap = new Intent(getContext(), MapActivity.class);
        showMap.putExtra(MapActivity.COORD, longitude);
        showMap.putExtra(MapActivity.COORD, latitude);
        showMap.putExtra(MapActivity.COORD, tour);
        startActivity(showMap);

    }

And this is MapActivity:

Java

public class MapActivity extends AppCompatActivity implements OnMapReadyCallback, LocationSource.OnLocationChangedListener {


    public static final String COORD = "coord";
    private GoogleMap.OnMapClickListener mCustomOnMapClickListener;

    private GoogleMap mGoogleMap;
    LocationManager mLocationManager;
    private Criteria mCriteria;
    private String mShowMap;


    private LocationSource.OnLocationChangedListener mListener;
    @BindView(R.id.lvTours)
    ListView lvTours;
    private SupportMapFragment mSupportMapFragment;


    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.tours_coord);
        this.mSupportMapFragment = (SupportMapFragment) this.getSupportFragmentManager().findFragmentById(R.id.fGoogleMap);
        this.mSupportMapFragment.getMapAsync(this);
        this.mCriteria = new Criteria();
        this.mCriteria.setAccuracy(Criteria.ACCURACY_FINE);
        this.mLocationManager = (LocationManager) this.getSystemService(LOCATION_SERVICE);
        this.mCustomOnMapClickListener = new GoogleMap.OnMapClickListener() {
            @Override
            public void onMapClick(LatLng latLng) {
                MarkerOptions newMarkerOptions = new MarkerOptions();
                newMarkerOptions.icon(BitmapDescriptorFactory.fromResource(R.mipmap.tour));
                newMarkerOptions.title("Tour");
                newMarkerOptions.snippet("It' was here!");
                newMarkerOptions.position(latLng);
                mGoogleMap.addMarker(newMarkerOptions);

                this.handleStartingIntent();

            }

            private void handleStartingIntent() {
                Bundle bundle = getIntent().getExtras();
                if (bundle.containsKey(COORD)) {
                    mShowMap = bundle.getString(COORD);

                }


            }
        };
    }


    @Override
    public void onMapReady(GoogleMap googleMap) {
        this.mGoogleMap = googleMap;
        UiSettings uiSettings = this.mGoogleMap.getUiSettings();
        uiSettings.setZoomControlsEnabled(true);
        uiSettings.setMyLocationButtonEnabled(true);
        uiSettings.setZoomGesturesEnabled(true);
        this.mGoogleMap.setOnMapClickListener(this.mCustomOnMapClickListener);
        // goToLocation(33.835293 , -117.914505);
    }


    @Override
    public void onLocationChanged(Location location) {


        if (mListener != null) {
            mListener.onLocationChanged(location);

            //Move the camera to the user's location and zoom in!
            mGoogleMap.animateCamera(CameraUpdateFactory.newLatLngZoom(new LatLng(location.getLatitude(), location.getLongitude()), 12.0f));
        }


    }


    public void goToLocation(double lat, double lng) {

        LatLng latLng = new LatLng(lat, lng);


        CameraPosition position = CameraPosition.builder()
                .target(latLng)
                .zoom(16f)
                .bearing(0.0f)
                .tilt(0.0f)
                .build();

        mGoogleMap.animateCamera(CameraUpdateFactory.newCameraPosition(position), null);


    }
}

I would be grateful to anyone who would make me an example on how to solve this.Thanks.

What I have tried:

It tried to found a solution using Google.

Posted 9-Jan-18 2:45am

Member 13593129

Add a Solution

Comments

David Crow 9-Jan-18 10:37am

What exactly is happening? Is an exception being thrown? Does a map open but it is the wrong location? Be specific.

I see that you are storing latitude, longitude and tour all using the same key. Then when you are reading that key in handleStartingIntyent(), you don't do anything with it. Is that intentional.

Member 13593129 10-Jan-18 5:32am

It's not intentional, but I'll try your code that you provided, and let you know.

Member 13593129 10-Jan-18 9:21am

It doesn't work. I get NP on "private double dLongitude = 0.0;" and "setContentView(R.layout.tours_coord);". I'll post how it looks now.

public class MapActivity extends FragmentActivity implements OnMapReadyCallback {

private double dLatitude = 0.0;
private double dLongitude = 0.0;

public static final String COORD = "coord";
private String mTours;

private GoogleMap mMap;
private GoogleMap.OnMapClickListener mCustomOnMapClickListener;

@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.tours_coord);

// Obtain the SupportMapFragment and get notified when the map is ready to be used.
SupportMapFragment mapFragment = (SupportMapFragment) getSupportFragmentManager().findFragmentById(R.id.fGoogleMap);
mapFragment.getMapAsync(this);

Bundle bundle = getIntent().getExtras();
dLatitude = bundle.getDouble("LATITUDE");
dLongitude = bundle.getDouble("LONGITUDE");
if (bundle.containsKey(COORD)) {
mTours = bundle.getString(COORD);
}
}

@Override
public void onMapReady(GoogleMap googleMap) {

mMap = googleMap;

LatLng latlng = new LatLng(dLatitude, dLongitude);
mMap.addMarker(new MarkerOptions().position(latlng).title("It was here"));
mMap.moveCamera(CameraUpdateFactory.newLatLng(latlng));
this.mCustomOnMapClickListener = new GoogleMap.OnMapClickListener() {
@Override
public void onMapClick(LatLng latLng) {
MarkerOptions newMarkerOptions = new MarkerOptions();
newMarkerOptions.icon(BitmapDescriptorFactory.fromResource(R.mipmap.tour));
newMarkerOptions.title("Tour");
newMarkerOptions.snippet("It' was here!");
newMarkerOptions.position(latLng);
mMap.addMarker(newMarkerOptions);

}
};
}
}

@OnItemClick(R.id.lvTours)
public void onItemClick(int position) {

String t = ((Tours)lvTours.getAdapter().getItem(position)).getCoord();
Intent i = new Intent(getContext(), MapActivity.class);
i.putExtra("LATITUDE", 33.835293);
i.putExtra("LONGITUDE", -117.914505);
i.putExtra(MapActivity.COORD, t);
startActivity(i);

}

David Crow 10-Jan-18 10:45am

"It doesn't work. I get NP on 'private double dLongitude = 0.0;'"

I'm not sure how that's possible since there are no objects involved. Is a NullpointerException exception being thrown? How are you verifying this?

The call to setContentView() is fine (again, no objects), but something internally might have gone awry when the framework attempted to inflate the tours_coord layout.

Member 13593129 10-Jan-18 11:36am

I was being a idiot. I forgot to put API_KEY, that's why it didn't work. Although, I have one more question.It works, it shows just one location, though.I want when I click on every item, to show other place. Cause I have 27 tours, and they weren't on same place. Do you have an idea how to do that?

David Crow 10-Jan-18 11:40am

In the onMapReady() method, make additional calls to addMarker().

Member 13593129 11-Jan-18 7:32am

Now everything works, except one thing. I have stored my coord(lat, lng) on Firebase, and the problem is on whatever item I clicked, it always opens same place(Anaheim), cause those coord are here:

i.putExtra("LATITUDE", 33.835293);
i.putExtra("LONGITUDE", -117.914505);

I tried to change that on this way, but it doesn't work:

@OnItemClick(R.id.lvTours)
public void onItemClick(int position) {

String t = ((Tours)lvTours.getAdapter().getItem(position)).getLat();
String tr = ((Tours)lvTours.getAdapter().getItem(position)).getLng();
Intent i = new Intent(getContext(), MapActivity.class);
i.putExtra("Lat", 33.835293);
i.putExtra("Lng", -117.914505);
i.putExtra(MapActivity.Lat, t);
i.putExtra(MapActivity.Lng, tr);
startActivity(i);

}
}

And in MapActivity:

Bundle bundle = getIntent().getExtras();
dLatitude = bundle.getDouble("Lat");
dLongitude = bundle.getDouble("Lng");
if (bundle.containsKey(Lat)) {
mTours = bundle.getString(Lat, Lng);
}

This is the last problem I have. After that, I won't bother you no more.
A big thanks for your help.

David Crow 11-Jan-18 8:38am

Your last two calls to putExtra() are using MapActivity.Lat and MapActivity.Lng, but your two calls to getDouble() are using "Lat" and "Lng" keys.

In addition, t and tr are String types while dLatitude and dLongitude are double types.

Member 13593129 11-Jan-18 10:20am

How do you think I should solve this?

David Crow 11-Jan-18 10:22am

Seriously?

dLatitude = bundle.getDouble(Lat);
dLongitude = bundle.getDouble(Lng);

Member 13593129 11-Jan-18 10:24am

I have that already. And it works, the problems is that opens map with same location.

David Crow 11-Jan-18 10:35am

"I have that already."

I don't think so.

"...the problems is that opens map with same location."

Because you are pulling the static coordinates from the bundle (rather than those from Firebase).

Member 13593129 11-Jan-18 10:49am

Ok, I get that. How to change that, so that pulls lat and lng from Firebase, and not from bundle?

David Crow 11-Jan-18 11:20am

Aren't you already getting the coordinates with:

String t = ((Tours)lvTours.getAdapter().getItem(position)).getLat();
String tr = ((Tours)lvTours.getAdapter().getItem(position)).getLng();

Regardless of where they come from, you still need to put them in the Intent's bundle so they can be retrieved in onMapReady().

Member 13593129 11-Jan-18 11:22am

From some reason it doesn't do that.Don't know what's the issue.
I did the same for YT videos, where I have URL stored on FB, and it works flawlessly.

David Crow 11-Jan-18 11:40am

So then what's being stored in t and tr?

Member 13593129 11-Jan-18 11:53am

As you can see. In first one latitude, and in second one longitude.

David Crow 11-Jan-18 11:55am

Earlier you said, "From some reason it doesn't do that. Don't know what's the issue." And prior to that you said, "How to change that, so that pulls lat and lng from Firebase." These contradict what you just said. Either you are getting the coordinates or you aren't. Which is it?

Member 13593129 11-Jan-18 11:58am

I don't get the coord.

David Crow 11-Jan-18 12:02pm

Then displaying a map with markers is not the issue here (or at least it isn't anymore). Start a new thread, preferably in the actual Android forum, to talk about the actual problem with pulling data from a Firebase store.

Member 13593129 11-Jan-18 12:05pm

Ok. Thanks for your help.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

David Crow · Accepted Answer · 2018-01-09T05:41:00

The minimum amount of code I can think of to open a map looks like:

activity_maps.xml:

<fragment xmlns:android="http://schemas.android.com/apk/res/android"
          xmlns:map="http://schemas.android.com/apk/res-auto"
          xmlns:tools="http://schemas.android.com/tools"
          android:id="@+id/map"
          android:name="com.google.android.gms.maps.SupportMapFragment"
          android:layout_width="match_parent"
          android:layout_height="match_parent" />

public class MainActivity extends AppCompatActivity
{
    @Override
    protected void onCreate( Bundle savedInstanceState )
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_maps);

        Intent intent = new Intent(this, MapsActivity.class);
        intent.putExtra("LATITUDE", 38.65452);
        intent.putExtra("LONGITUDE", -90.18471);
        startActivity(intent);
    }
}

public class MapsActivity extends FragmentActivity implements OnMapReadyCallback
{
    private double dLatitude = 0.0;
    private double dLongitude = 0.0;

    private GoogleMap mMap;

    //================================================================

    @Override
    protected void onCreate( Bundle savedInstanceState )
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_maps);

        Bundle bundle = getIntent().getExtras();
        dLatitude = bundle.getDouble("LATITUDE");
        dLongitude = bundle.getDouble("LONGITUDE");

        // Obtain the SupportMapFragment and get notified when the map is ready to be used.
        SupportMapFragment mapFragment = (SupportMapFragment) getSupportFragmentManager().findFragmentById(R.id.map);
        mapFragment.getMapAsync(this);
    }

    //================================================================

    @Override
    public void onMapReady( GoogleMap googleMap )
    {
        mMap = googleMap;

        LatLng latlng = new LatLng(dLatitude, dLongitude);
        mMap.addMarker(new MarkerOptions().position(latlng).title("Marker"));
        mMap.moveCamera(CameraUpdateFactory.newLatLng(latlng));
    }
}

You can add to it from here.