Function 'fnc' doesn't return a value

Question

0.00/5 (No votes)

See more:

Hello to all,
Could someone tell me why I am getting this warning and how to solve it.
Code works fine but I would like to know how to avoid warnings like this in the future.

VB

Public Function GetPropertyValue(objBlockRef As AcadBlockReference, propName As String) As Object
        Dim iProp As Long
        Dim dybprop As Object

        If objBlockRef.IsDynamicBlock Then '<--| if the passed block reference is a dynamic block one
            dybprop = objBlockRef.GetDynamicBlockProperties '<--| get its dynamic properties
            For iProp = LBound(dybprop) To UBound(dybprop) '<--| iterate through them properties
                With dybprop(iProp)
                    If .PropertyName = propName Then '<--| if the current property matches the passed name
                        GetPropertyValue = .Value '<--| return its value
                        Exit Function
                    End If
                End With
            Next
        End If

    End Function

What I have tried:

I don't have any idea. I have tried to use "return" on the name of the function.

Posted 25-Nov-17 13:02pm

blueye89

Updated 25-Nov-17 15:23pm

PIEBALDconsult

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2017-11-25T14:01:00

You don't have a single Return statement anywhere. This isn't VB6 or VBScript.

An actual Return statement has to be in there, and in an appropriate place. If you replace the GetPropertyValue = .Value with the Return statement, you'll get another error, "Not all code paths return a value."

So, rewrite the function

VB.NET

Public Function GetPropertyValue(objBlockRef As AcadBlockReference, propName As String) As Object
    Dim iProp As Long
    Dim dybprop As Object
    Dim returnValue As Object = Nothing

    If objBlockRef.IsDynamicBlock Then '<--| if the passed block reference is a dynamic block one
        dybprop = objBlockRef.GetDynamicBlockProperties '<--| get its dynamic properties
        For iProp = LBound(dybprop) To UBound(dybprop) '<--| iterate through them 
properties
            ' The With was completely unnecessary.
            If dybprop(iProp).PropertyName = propName Then '<--| if the current property matches the passed name
                returnValue = dybprop(iProp).Value '<--| return its value
                Exit For
            End If
        Next
    End If

    Return returnValue
End Function