How to write a cstringarray to file

Question

0.00/5 (No votes)

See more:

i want to write CStringArray to file, how can i do that ?

What I have tried:

CStringArray RegKeys;
for(int i = 0; i < RegKeys.GetCount(); i++)
	{

	CString str;
	
	str = RegKeys.GetAt(i);
	CFile file;
	if (!file.Open(_T("Test1.txt"),  CFile::modeWrite))
		return true;
	file.Write((LPCTSTR)str, str.GetLength() * sizeof(TCHAR));
	file.Close();

	}

Posted 28-Aug-17 3:07am

srilekhamenon

Updated 28-Aug-17 3:45am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Accepted Answer · 2017-08-28T03:45:00

Your code should actually write (and append) single strings from the array to the file.

But you should think about how the reader can distinguish the strings. This can be done by writing a new line sequence ("\r\n" Windows style or "\n" Unix style) creating a plain text file (which might be Unicode encoded) or by appending the trailing NULL bytes:

// New line separated
file.Write((LPCTSTR)str, str.GetLength() * sizeof(TCHAR));
file.Write(_T("\r\n"), 2 * sizeof(TCHAR));

// With null byte
file.Write(str.GetString(), (str.GetLength() + 1) * sizeof(TCHAR));

But the simplest method is using serialization which is supported by CStringArray:

CFile file(_T("Test1.txt"), CFile::modeCreate | CFile::modeWrite);
CArchive ar(&file, CArchive::store);
RegKeys.Serialize(ar);

Which method to use is up to you but you have to use a corresponding read method.

When not using serialization you should also move the file opening and closing out of the loop:

CFile file;
if (file.Open(_T("Test1.txt"),  CFile::modeWrite))
{
    // Loop to write strings goes here
    file.Close();
}