Setting max ID criteria in ms access SQL

Question

1.00/5 (1 vote)

See more:

This query does not run at the beginning. Could someone please help look at what is wrong?
This query does not run at the beginning. Could someone please help look at what is wrong?

What I have tried:

<pre>    strSQL1 = "SELECT * FROM PharmSales WHERE HospitalNo='" & Me.txtRegNo & "' And TDate = #" & Format(Me.txtTDate, "M\/dd\/yyyy") & "# AND SalesItem1 = '" & Me.txtSalesItem1 & "' And PharmSalesID=  (SELECT MAX(PharmSalesID) FROM PharmSales)"
            
        Set pr = db.OpenRecordset(strSQL1)
        
        With pr
        If Not .BOF And Not .EOF Then  'Ensure that the recordset contains records
        .MoveLast
        .MoveFirst
         If .Updatable Then  'To ensure record is not locked by another user
         .Edit  'Must start an update with the edit statement
         If IsNull(![TotalPaid]) = True And Me.txtGrand_TotalPay.Value >= Me.txtSalesAmt1.Value Then
         ![DispQty1] = Nz(![DispQty1] + Me.txtSalesQty1.Value, 0)
          .Update
               ElseIf IsNull(![TotalPaid]) = False And (Me.txtGrand_TotalPay.Value - Me.txtSalesAmt1.Value) >= (txtGrand_TotalFee - Me.txtGrand_TotalPay.Value + Me.txtSalesAmt1.Value) Then
         ![DispQty1] = Nz(![DispQty1] + Me.txtSalesQty1.Value, 0)
          .Update
        
         Else: MsgBox ("Insufficient balance!")
         End If
        End If
        End If
    
         pr.Close 
         Set pr = Nothing 
        Set db = Nothing
        End With
    
    End Sub

Posted 21-Aug-17 5:17am

Liberty Crown Infotech

Updated 21-Aug-17 5:42am

Add a Solution

Comments

Richard Deeming 21-Aug-17 13:28pm

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-08-21T05:42:00

For starters, don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

Secondly, the default ToString implementation for a TextBox always returns a string like this: "System.Windows.Forms.TextBox, Text: ..." - it does not return the Text property.
So your WHERE clauses are unlikely to match anything at all, so no rows will be returned.