Window.location.href pass a wrong parameter to the controller

Question

3.00/5 (2 votes)

See more:

In my view, I want to pass parameters to the controller.

window.location.href = "@Url.Action("index", "Survey")?languageName="
                   + selectedValue + "&id=@Model.CampaignGuid";

My controller:

public ActionResult Index(Guid id, string languageName)
       {

I am sure that the query string is correct. In the query string, I saw the languageName is "Spanish". But when I set a break point in the Index method, it becomes "English" always.This happens even if I I totally close out of the page and reload it, almost as if it's cached somewhere. I know this is something simple, but I've never run across this before.

I have the route

routes.MapRoute("SurveyWelcomeRoute", "Survey/{id}/{languageName}",
                            defaults: new { action = "Index", controller = "Survey", languageName="English" });

What I have tried:

I found a similar one at ASP.NET MVC RedirectToAction Passing Wrong Parameter Value? - Stack Overflow[^]
But I still don't know the cause. I have spent more than 7 hours. No clue.

Posted 9-Aug-17 6:43am

Member 12658724

Updated 9-Aug-17 22:43pm

Add a Solution

Comments

Kornfeld Eliyahu Peter 9-Aug-17 14:24pm

What is the actual HTML generated?
Survey/Index/English?languageName=Spanish&id=...?

Member 12658724 9-Aug-17 14:31pm

http://localhost:17671/Survey/ab7f6bda-9f5e-44d7-9bd2-63c24e6b6adb?languageName=Spanish&id=ab7f6bda-9f5e-44d7-9bd2-63c24e6b6adb

2 solutions

Solution 1

There are two things...
One is your mixing different approaches for URL creation... There is the old-and-good HTTP URL ENCODING with the http://site-address/page.html?param1=value1&param2=value2. And there is the MVC ROUTING which uses the form of http://site-address/page/value1/value2.
You can not mix them and expect the correct behavior...
The second one is a common mistake. We all overlook the documentation about UrlHelper.Action, that explains that the function will create an URL according to the matching mapping from the route table...
In your case 'Index' omitted as it is the default action, than id added as it is requested but not optional ('English' isn't there for the same reason as 'Index')... then comes your part...

SQL

http://localhost:17671 -- site address
Survey -- controller
-- action is missing, as it has a default value
ab7f6bda-9f5e-44d7-9bd2-63c24e6b6adb -- id value (from model)
-- languageName missing, as it has a default value
?languageName=Spanish&id=ab7f6bda-9f5e-44d7-9bd2-63c24e6b6adb -- the part you wrote

So - you have two options, one to use the id value you already have from the model or use an another (in your case it seems to be the first)...

JavaScript

location href = "@Url.Action("Index", "Survey")" + "/" + selectedValue"

Or

JavaScript

location.href = "@Url.Action("Index", "Survey", new { id = UrlParameter.Optional })" + "/" + "@Model.CampaignGuid" + "/" + selectedValue

Posted 9-Aug-17 8:48am

Kornfeld Eliyahu Peter

Updated 9-Aug-17 20:17pm

v5

Comments

Member 12658724 10-Aug-17 8:25am

I use your first code. It is working first time. The second time if I select "Spanish" again, the url becomes http://localhost:17671/Survey/ab7f6bda-9f5e-44d7-9bd2-63c24e6b6adb/Spanish/Spanish. You see there are two "Spanish" at the end of the url.

One thing I still don't understand is why you did not add id into the url? I thought you override the url, and the url didn't have the id value. Thus the id value would be lost?

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Accepted Answer · 2017-08-09T22:43:00

I don't think you need the custom route, not sure if it's only confusing you. But with your route the url needs to be

/Survey/id/language

so

/Survey/b4cc6a5a-9f2a-4e61-9815-9709b43a26a3/Spanish

as you can see the url you are generating is nothing like that. Also if you want to create a path that has a custom route there is a different method call for that

window.location.href = "@(Url.RouteUrl("SurveyWelcomeRoute", new { id = Model.CampaignGuid, languageName = UrlParameter.Optional }))/" + encodeURI(selectedValue);