Is there any difference between those two implementations on sockets?

Question

0.00/5 (No votes)

See more:

I've made a client/Server app using TCP sockets, but clients stuck too often and they throw "Connection timed out" while reading for new messages from the Server.
On both apps im using this:

Java

try{
   do{
     message=(String) input.readLine();

     System.out.println(message);

   }while(!message.equals("Disconnect"));
 }catch (IOException e) {
    System.out.println(e.getMessage());
 }

But at examples i've seen, the do these:

Java

do{
  try{
     message=(String) input.readLine();

     System.out.println(message);

  }catch (IOException e) {
     System.out.println(e.getMessage());
  }
}while(!message.equals("Disconnect"));

Is there any major difference to use "try" out of the "do{}while" than using "try" inside the "do{}while"?

What I have tried:

Until now i have tested both ways but i didnt managed to recreate the error.

Posted 31-Jul-17 3:19am

Member 13337752

Updated 31-Jul-17 3:25am

Add a Solution

Comments

Jochen Arndt 31-Jul-17 9:34am

There is no great difference but the second is the usual option (catch exceptions for the code portion that may throw).

However, in your example the second option would not leave the loop upon errors while the first does.

But there is no relation to network timeout errors. Solving those requires knowing how your communication works.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2017-07-31T03:25:00

Yes, there is a difference.

In the first code block, when there's an error in the try block, you exit the do-while loop and go into catch. readLine does not get called anymore, because the code that goes after the catch block gets executed now.

In the second code block, when there's an error in the try block, you do not exit the do-while loop (because try-catch is inside the loop). So, in case of an error, after the code in catch is executed, the loop continues to run and readLine gets executed again.