C# winform : SEND CHECKBOX VALUE to DATABASE ACCESS

Question

0.00/5 (No votes)

See more:

Hye, this is my code to change the checkbox value to String and send to Database. But, i cannot save to my database.

thank you,

What I have tried:

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.Data.OleDb;

namespace Checkbox_Database
{
    public partial class Form1 : Form
    {

        //OPEN CONNECTION
        OleDbConnection con = new OleDbConnection(@"");

        String gen;

        public Form1()
        {
            InitializeComponent();
        }

        private void Form1_Load(object sender, EventArgs e)
        {
            // TODO: This line of code loads data into the 'cHECKBOX_DATABASEDataSet.Table1' table. You can move, or remove it, as needed.
            this.table1TableAdapter.Fill(this.cHECKBOX_DATABASEDataSet.Table1);

        }

        private void button1_Click(object sender, EventArgs e)
        {
            //Checkbox

            if (checkBox1.Checked == true)
            {
                gen = "Male";
            }
            else if (checkBox2.Checked == true)
            {
                gen = "female";
            }

            try
            {
                con.Open();
                OleDbCommand cmd = con.CreateCommand();
                cmd.CommandText = "insert into Table1 values('" + textBox1.Text + "','"+ gen +"')";
                cmd.ExecuteNonQuery();
                con.Close();
                MessageBox.Show("Record insert Succesfully");
            }
            catch (Exception ex)
            {
                MessageBox.Show(ex.ToString());
            }


        }
    }
}

Posted 27-Jul-17 22:40pm

Asyraf Patt

Updated 27-Jul-17 23:03pm

Add a Solution

Comments

Karthik_Mahalingam 28-Jul-17 4:54am

what is the error message?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-07-27T23:03:00

Don't do it like that! Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.

There is also the likelihood that your INSERT is not working beause you don;t specify the fields:

C#

cmd.CommandText = "insert into Table1 values('" + textBox1.Text + "','"+ gen +"')";

When you insert like this, SQL starts inserting values from the first column onward - which is dangerous, because if the columns get reordered for any reason, your code inserts into the wrong rows and either crashes, or worse fills your db with a mixture of valid and invalid data. Plus, if you have a row ID column which is an IDENTITY column say, they are generally the first column, and you can't set a value to them - SQL will complain if you try.
Always specify the fields, always use parameterised queries:

C#

cmd.CommandText = "INSERT INTO Table1 (myColumn1, myColumn2)  VALUES(@V1, @V2)"
cmd.Parameters.AddWithValue("@V1", textBox1.Text);
cmd.Parameters.AddWithValue("@V2". gen);