A little guidance for a beginner

Question

0.00/5 (No votes)

See more:

I do not understand the issue is in my code, I have not seen an error like this so I don't know where to start to debug it. I have only been learning to write code in C++ for about a month now. So, the issue is this "No suitable conversion function from const std::string to char exist." in this line of code "horses[i].name = HorseNames[i];" under HorseNames.

edit:: I add the declaration

C++

struct Horse
{
	char name;
	int distance;
	int eventOffSet;
	int ID;
};

        array <Horse, horseCount> horses;
	const string HorseNames[] = { "Black Beauty", "Sea Biscuit", "Bucephalus", 
                                      "Man o War", "Marengo", "Winning Colors" };

	horses[0].ID = 1;
	horses[1].ID = 2;
	horses[2].ID = 3;
	horses[3].ID = 4;
	horses[4].ID = 5;
	horses[5].ID = 6;


 for (int i = 0; i < horseCount; i++)
		{
			horses[i].name = HorseNames[i];
			cout << "These are the Galent Steeds racing today!: "  
                             <<  horses[i].name << endl;
		}

What I have tried:

I have googled it and couldn't find anything, I tried to change my const string to a static, renamed it to char and nothing seemed to work.

Posted 27-Jul-17 14:59pm

Irdia_36

Updated 28-Jul-17 5:35am

v2

Add a Solution

Comments

[no name] 27-Jul-17 21:03pm

Post a small snippet of code showing where horses and HorseNames are declared.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Answer 1 · 2017-07-27T21:40:00

As already suggested you should show the declaration of the tpyes.

However, from the error message something like this can be assumed:

C++

std::string HorseNames[MAX_HORSES];
struct {
    char name;
    // Probably more members here
} Horses;
Horses horses[MAX_HORSES];

Then HorseNames[i] is a std::string which can not be assigned to a single char like horses[i].name.

You probably want Horses.name to be a std::string too or a char array. In the latter case you could not use an assignment but have to copy the string:

C++

char name[MAX_NAME_LEN];
// Use strncpy or a safe string copy method here to avoid buffer overruns
strncpy(name, HorseNames[i], sizeof(name) / sizeof(name[0]));
// NULL terminate when using strncpy and string is too long
name[sizeof(name) / sizeof(name[0]) - 1] = '\0';

Richard MacCutchan · Answer 2 · 2017-07-28T05:35:00

Solution 2

You cannot store a string in a char variable; a char type can hold only a single character. You need either a pointer to a string (char*), or a character array (char[]) as Jochen has suggested above.

Posted 28-Jul-17 5:35am

Richard MacCutchan