Where to use try and catch to handle exception in following code?

Question

1.00/5 (1 vote)

See more:

I want to handle use try and catch in code but I don't know where to use in my following code

What I have tried:

private void btnPUpdate_Click(object sender, EventArgs e)
       {
           if ((txtPVNumber.Text == "") || (cboPVColor.Text == "") || (cboPVType.Text == "") || (cboPVBrand.Text == "") || (txtPDaysLeft.Text == "") || (txtPOName.Text == "") || (txtPCivilID.Text == "") || (txtPTelephone.Text == ""))
           {
               MessageBox.Show("Please select a recored to Update");
           }
           else
           {



               DialogResult upd = MessageBox.Show("Are you Sure you want to Update?" + txtPVNumber.Text + "", "Update", MessageBoxButtons.YesNo, MessageBoxIcon.Question);

               if (upd == DialogResult.Yes)
               {
                   using (var connection = new SqlConnection(@"Data Source=DESKTOP-F1TCIFJ;Initial Catalog=tempdb;Integrated Security=True"))
                   {
                       using (var command = new SqlCommand("UPDATE personal SET VNumber, VColor, VType, VBrand, ExpiryDate, DaysLeft, OName, CivilID, Telephone ) VALUES (@vnumber, @vcolor, @vtype, @vbrand, @expirydate, @daysleft, @ownername, @civilid, @telephone )", connection))
                       {


                           command.Parameters.AddWithValue("@vcolor", cboPVColor.Text);
                           command.Parameters.AddWithValue("@vtype", cboPVType.Text);
                           command.Parameters.AddWithValue("@vbrand", cboPVBrand.Text);
                           command.Parameters.AddWithValue("@expirydate", dateTimePickerPersonal.Value.ToString("MM/dd/yyyy"));
                           command.Parameters.AddWithValue("@daysleft", txtPDaysLeft.Text);
                           command.Parameters.AddWithValue("@ownername", txtPOName.Text);
                           command.Parameters.AddWithValue("@civilid", txtPCivilID.Text);
                           command.Parameters.AddWithValue("@telephone", txtPTelephone.Text);
                           connection.Open();
                           command.ExecuteNonQuery();

                           MessageBox.Show("Record Updated Successfully");
                           txtPVNumber.Text = "";
                           cboPVColor.Text = "";
                           cboPVType.Text = "";
                           cboPVBrand.Text = "";
                           dateTimePickerPersonal.Value = DateTime.Now;
                           txtPDaysLeft.Text = "";
                           txtPOName.Text = "";
                           txtPCivilID.Text = "";
                           txtPTelephone.Text = "";
                           btnPSave.Enabled = true;
                       }
                   }

               }
               else
               {
                   txtPVNumber.Text = "";
                   cboPVColor.Text = "";
                   cboPVType.Text = "";
                   cboPVBrand.Text = "";
                   dateTimePickerPersonal.Value = DateTime.Now;
                   txtPDaysLeft.Text = "";
                   txtPOName.Text = "";
                   txtPCivilID.Text = "";
                   txtPTelephone.Text = "";
                   btnPSave.Enabled = true;
                   this.Show();
               }
           }
       }

Posted 5-Jul-17 8:07am

Member 13151446

Updated 5-Jul-17 8:51am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RickZeeland · Answer 1 · 2017-07-05T08:51:00

It's simple, if you don't know where put everything in a try ... catch :)
When you find later that you need more specific error catching you can always add more.
Example:

C#

try
    {
       // your code ...
    }
    catch (Exception ex)
    {
        Debug.WriteLine("Exception Message: " + ex.Message);
    }