Code optimization C# ASP MVC

Question

1.00/5 (2 votes)

See more:

So these are the methods that handle picture upload in the controller .

[HttpPost]
        [ValidateAntiForgeryToken]
        public ActionResult Edit([Bind(Include = "AlbumId,GenreId,ArtistId,Title,Price,AlbumArtUrl")] Album album, HttpPostedFileBase file)
        {
            if (ModelState.IsValid)
            {
              
          
                if (file != null)
                {
                    file.SaveAs(HttpContext.Server.MapPath("/Content/Images/") + file.FileName);
                    album.AlbumArtUrl = ("/Content/Images/") + file.FileName;
                }
                db.Entry(album).State = EntityState.Modified;
                db.SaveChanges();
                return RedirectToAction("Index");
            }
            ViewBag.ArtistId = new SelectList(db.Artists, "ArtistId", "Name", album.ArtistId);
            ViewBag.GenreId = new SelectList(db.Genres, "GenreId", "Name", album.GenreId);
            return View(album);
        }

[HttpPost]
       [ValidateAntiForgeryToken]
       public ActionResult Create([Bind(Include = "AlbumId,GenreId,ArtistId,Title,Price,AlbumArtUrl")] Album album, HttpPostedFileBase file)
       {
           if (ModelState.IsValid)
           {
               if (file != null)
               {
                  file.SaveAs(HttpContext.Server.MapPath("/Content/Images/")+file.FileName);
                   album.AlbumArtUrl = ("/Content/Images/")+file.FileName;
               }


               db.Albums.Add(album);
               db.SaveChanges();
               return RedirectToAction("Index");
           }

           ViewBag.ArtistId = new SelectList(db.Artists, "ArtistId", "Name", album.ArtistId);
           ViewBag.GenreId = new SelectList(db.Genres, "GenreId", "Name", album.GenreId);
           return View(album);
       }

SO basicaly first lines of methods are the same , and what i want is to create a separate method called Upload , and call it inside Create() and Edit () . Is is possible , could anyone guide me or tell me how ? Thanks.

What I have tried:

I explained above the question.

Posted 21-Jun-17 2:54am

ddgjgj

Updated 21-Jun-17 17:52pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2017-06-21T17:52:00

try

[HttpPost]
        [ValidateAntiForgeryToken]
        public ActionResult Edit([Bind(Include = "AlbumId,GenreId,ArtistId,Title,Price,AlbumArtUrl")] Album album, HttpPostedFileBase file)
        {
            return CreateEdit(file, album, false);
        }
        [HttpPost]
        [ValidateAntiForgeryToken]
        public ActionResult Create([Bind(Include = "AlbumId,GenreId,ArtistId,Title,Price,AlbumArtUrl")] Album album, HttpPostedFileBase file)
        {
            return CreateEdit(file, album, true);
        }

        private ActionResult CreateEdit(HttpPostedFileBase file,Album album,  bool isCreate)
        {
            if (ModelState.IsValid)
            { 
                if (file != null)
                {
                    file.SaveAs(HttpContext.Server.MapPath("/Content/Images/") + file.FileName);
                    album.AlbumArtUrl = ("/Content/Images/") + file.FileName;
                }
                if(isCreate)
                    db.Albums.Add(album);
                else
                db.Entry(album).State = EntityState.Modified;
                db.SaveChanges();
                return RedirectToAction("Index");
            }


            ViewBag.ArtistId = new SelectList(db.Artists, "ArtistId", "Name", album.ArtistId);
            ViewBag.GenreId = new SelectList(db.Genres, "GenreId", "Name", album.GenreId);
            return View(album);
        }