How to record number of clicks within a time limit

Question

1.00/5 (1 vote)

See more:

I tried making an app where the user gets 20 seconds to click a button and at the end of the time the total number of clicks are recorded and displayed
The program is neither terminating nor executing

What I have tried:

private TextView t1;
private Button btn;
private int count = 0;
private long startTime = System.currentTimeMillis();
private long endTime = System.currentTimeMillis()+20000;

@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);

t1 = (TextView)findViewById(R.id.textView);
btn = (Button)findViewById(R.id.button);

while(startTime < endTime)
{
btn.setOnClickListener(new View.OnClickListener()
{

@Override
public void onClick(View view)
{
count = count + 1;
}
});
}
t1.setText(Integer.toString(count));
}

Posted 13-Jun-17 9:26am

Member 13257642

Updated 14-Jun-17 12:05pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2017-06-14T12:04:00

while (startTime < endTime)

First problem: you're comparing two fixed values, which are initialized once and then never change.

You're going to want to replace startTime with System.currentTimeMillis().

btn.setOnClickListener(new View.OnClickListener() ...

Second problem: you're never asking the code to terminate. Instead, you're adding a new "click" handler over and over again in a tight loop.

A simple solution would be to add the handler once, and check the time limit within the onClick method:

private TextView t1;
private Button btn;
private int count = 0;
private long endTime;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    
    endTime = System.currentTimeMillis() + 20000;
    t1 = (TextView)findViewById(R.id.textView);
    
    btn = (Button)findViewById(R.id.button);
    btn.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            if (System.currentTimeMillis() < endTime) {
                count = count + 1;
                t1.setText(Integer.toString(count));
            }
        }
    });
}