C# controlling the time comparison in loop

Question

1.00/5 (1 vote)

See more:

Hello,

I give my code snipple down part.My problem is when i run this code i get false all time. How can i fix this?

C#

While(!isStop)
{
	var isReportOnly = false;
	var isInReportPeriod = false;

	DateTime dtStart = new DateTime(DateTime.Now.Year, DateTime.Now.Month, DateTime.Now.Day, 22, 0, 0);
	DateTime dtStop = new DateTime(DateTime.Now.Year, DateTime.Now.Month, DateTime.Now.Day, 06, 0, 0);
	if (DateTime.Now > dtStart && DateTime.Now < dtStop)
	{
		isInReportPeriod = true;
		log.Add( DateTime.Now.ToString() + "=True\n");
	}
	else
	{
		isInReportPeriod = false;
		log.Add(DateTime.Now.ToString() + "=False\n");
	}
}

What I have tried:

How can i fix the problem for time comprison in the loop

Posted 11-Jun-17 19:53pm

Member 10525430

Updated 11-Jun-17 20:25pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-06-11T20:25:00

Um.
Start is 22:00, stop is 06:00.
To log TRUE, you need the current time to be both after 22:00 and before 06:00 on the same day...

Possibly you got the start and stop times wrong?

But don't do it like that anyway: never read the time more than once, it can cause problems when the day, (or worse month or year) changes.

C#

DateTime now = DatetIme.Now;
DateTime start = now.Date.AddHours(6);
DateTime stop = now.Date.AddHours(22);
if (now > start && now < stop)
   {
   ...