Up/down buttons not getting disabled

Question

0.00/5 (No votes)

See more:

i have some items in list when i selected one item in list and clicked the up button continuosly still it reached top place and after its reched top place my up button should get disbaled.
but its not disbling and its deleting item when it recahes top place and after we clicked the up button.
could you please help me here

What I have tried:

C++

onupbuutonclicked(){

 int item2 = m_clist_ctl.GetNextItem(-1, LVNI_SELECTED);
        int columns = m_clist_ctl.GetHeaderCtrl()->GetItemCount();
        //Leaving out the order# column(0)
        for (int i = 1; i < columns; i++)
        {
            CString str1 = m_clist_ctl.GetItemText(item2 + 1, i);
            CString str2 = m_clist_ctl.GetItemText(item2, i);
            m_clist_ctl.SetItemText(item2 + 1, i, str2);
            m_clist_ctl.SetItemText(item2, i, str1);
          
        }
        m_clist_ctl.SetItemState(item2, ~LVNI_SELECTED, LVNI_SELECTED);
        m_clist_ctl.SetItemState(item2 + 1, LVNI_SELECTED, LVNI_SELECTED);

}

OnLvnItemchangedList(NMHDR *pNMHDR, LRESULT *pResult)
{
    LPNMLISTVIEW pNMLV = reinterpret_cast<lpnmlistview>(pNMHDR);
    // TODO: Add your control notification handler code here
    int count = m_clist_ctl.GetItemCount();
    int row = m_clist_ctl.GetSelectionMark();
    int lastRow = count - 1;
    if ((0 == count) || (row < 0)) {
 GetDlgItem(IDC_BUTTON_UP)->EnableWindow(FALSE);

               }
   else if ((count >= 2) && (row > 0)) {
            GetDlgItem(IDC_BUTTON_UP)->EnableWindow(TRUE);
        }
        else {
            GetDlgItem(IDC_BUTTON_UP)->EnableWindow(FALSE);
        }

   }

could you please tell me if anything si wrong in my code

Posted 6-Jun-17 23:23pm

Member 13089825

Updated 7-Jun-17 0:05am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Answer 1 · 2017-06-07T00:05:00

The reason is that OnLvnItemchangedList is not called when changing the selection. It is called when changing the content by calling SetItemText in onupbuutonclicked. But when that is processed the selection is still on the old position and the button is not disabled.

So you might disable the button at the end of onupbuutonclicked when item2 == 1 (but it looks like your posted code is for button down instead of button up because you are exchanging item2 and item2+1).

You may also use a single call to enable / disable the button in OnLvnItemchangedList:

// Enable button when current selection is not first row
// No need to check item count because that is always >= 2 when row >= 1
GetDlgItem(IDC_BUTTON_UP)->EnableWindow(row > 0);