Can I use generic best practice to the methods?

Question

0.00/5 (No votes)

See more:

Hi, I have the four methods, they are pretty similar.

C#

private void MovePieceToUpperStation(Button currentButton, string rowId, string colId)
       {
           if (rowId == "8")
               return;
           var nextButtonName = ButtonNameNextToCurrentOneGetter.GetButtonNameOfTheUpperStation(colId, rowId);
           MovePieceToNextStation(currentButton, nextButtonName);
       }

       private void MovePieceToLowerStation(Button currentButton, string rowId, string colId)
       {
           if (rowId == "1")
               return;
           var nextButtonName = ButtonNameNextToCurrentOneGetter.GetButtonNameOfTheLowerStation(colId, rowId);
           MovePieceToNextStation(currentButton, nextButtonName);
       }

       private void MovePieceToRightStation(Button currentButton, string rowId, string colId)
       {
           if (colId == "H")
               return;
           var nextButtonName = ButtonNameNextToCurrentOneGetter.GetButtonNameOfTheRightStation(rowId, colId);
           MovePieceToNextStation(currentButton, nextButtonName);
       }

       private void MovePieceToLeftStation(Button currentButton, string rowId, string colId)
       {
           if (colId == "A")
               return;
           var nextButtonName = ButtonNameNextToCurrentOneGetter.GetButtonNameOfTheLeftStation(rowId, colId);
           MovePieceToNextStation(currentButton, nextButtonName);
       }

My question is I do not want repeat them. Is there a good way to do that?
For example, using generic.

What I have tried:

May pass another parameter to the method?

Posted 18-May-17 3:44am

Member 12658724

Updated 18-May-17 4:36am

Add a Solution

3 solutions

Solution 2

Hello,

there's not much to simplify here.
You are calling a different method in each of them. That's not something that generic can help you with.

Posted 18-May-17 4:03am

jimmson

Solution 3

Those methods are only similar in structure, not in function. The problem is each method deals with different data and executes different code depending on different conditions imposed on that data.

There's no way to condense that code down to a single method in any elegant manner.

Posted 18-May-17 4:36am

Dave Kreskowiak

Updated 18-May-17 4:37am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2017-05-18T04:01:00

Not easily - they do different things that just look similar.
You'd need to pass three extra parameters: the "comparison id" (either rowId or ColId), the "compare value" ("8", "1", "H", or "A") and a delegate for the method to execute (GetButtonNameOfTheUpperStation, GetButtonNameOfTheLowerStation, GetButtonNameOfTheRightStation, or GetButtonNameOfTheLeftStation)
And that means that every call has to know the details of what is going to happen, and why in order to call the "common" method - that's messy and prone to error.

I wouldn't do it.