Unable to read the files recursively inside the directories using Perl?

Question

0.00/5 (No votes)

See more:

Am unable to read the files recursively inside the directories.Here $dir1 is the directory which has the file names with task recursively.I want to remove those files which starts with task recursively.How can i do it?

Error:

Use of uninitialized value in pattern match (m//) at ./generate_dcms_html.pl

My input_Directory struture:

`-- added
   |-- add.txt
   `-- added1
       |--action
       |   |-- action.txt
       |   `-- task1
       |   |    `-- task1.html
       |   `-- task2
       |       `-- task1.html

       `-- add.html

Expected:

`-- added
   |-- add.txt
   `-- added1
       |--action
       |   |-- action.txt
       |   `-- task2
       |       `-- task2.html

       `-- add.html

What I have tried:

sub ProcessDirectory1{
    my ($workdir1) = shift;
 	unless (-d $workdir1)
    {
        warn "argument to DelTask is not a directory.\n";
        return;
    }
    my @dirs1 =  glob "$workdir1/*";

    foreach my $f (@dirs1)
    {
    	my $dirs1=basename($f);
    	{
        if (my $dirs1 =~ /^task/)
        {
          my $filemask1 = $f.'/*';
          print $filemask1;
          unlink glob $filemask1;
          unlink $f;          
        }

        
    }
}
}
ProcessDirectory1($output_dir);

Posted 17-Apr-17 19:46pm

gps sana

Updated 18-Apr-17 23:15pm

v4

Add a Solution

Comments

Richard MacCutchan 18-Apr-17 2:58am

Yet another unclear/incomplete question. I explained yesterday (and previously) the information we need to see, but you still do not provide it.

gps sana 19-Apr-17 4:46am

I had showed you the information.Please look into it

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Answer 1 · 2017-04-17T21:31:00

Solution 1

The regex must be applied to an existing variable but you are trying to create a new one using my and there is an unnecessary brace:

PERL

my $dirs1=basename($f);
{
    if (my $dirs1 =~ /^task/)

So it should be:

PERL

my $dirs1=basename($f);
if ($dirs1 =~ /^task/)
# ...
# Remove closing brace too

You should also not use the name of an already existing variable (dirs1 is already used for an array). While this is possible it is bad style and makes finding errors difficult. This is better:

PERL

my $file_name=basename($f);
if ($file_name =~ /^task/)

[EDIT]
If you want to process directories recursively you have to call ProcessDirectory1 for sub directories:

PERL

foreach my $f (@dirs1)
{
    if (-d $f)
    {
        ProcessDirectory1($f);
    }
    else
    {
        my $filename=basename($f);
        # ...
    }
}

[/EDIT]

Posted 17-Apr-17 21:31pm

Jochen Arndt

Updated 18-Apr-17 23:01pm

v2

Comments

gps sana 19-Apr-17 0:05am

sub ProcessDirectory1{

my ($workdir) = shift;

my @dirs1 = glob "$workdir/*";

foreach my $f (@dirs1) {
chomp ($f);
my $file_name=basename($f);
if ($file_name =~ /^task/)
{
print "if";
my $filemask1 = $f.'/*';
print $filemask1;

unlink glob $filemask1;
unlink $f;
}

}

}
ProcessDirectory1($output_dir);

Still i have the problems print statements are not working.

Jochen Arndt 19-Apr-17 2:42am

The print statements are working.
But there is probably no file name beginning with "task" so that no print statement is reached in your code.

gps sana 19-Apr-17 4:42am

but i have files under the sub directories then why it is not reading those files.

Jochen Arndt 19-Apr-17 4:54am

The solution is simple:

You have no recursion!
You have to call ProcessDirectory1() again for each directory found in the actually processed directory.

I will update my answer.