How do I get all specific XML elements to show in view?

Question

0.00/5 (No votes)

See more:

I have a XML file with some data and want to retrieve all elements by the tag name of "ProjectNr" in Controller and then send the list to View showing the project numbers in a dropdownlist.

The problem with below code is that it only shows the last element of "ProjectNr" which means it overwrites each element until it reaches the end of the loop and then only the last remains.

I have tried to make it save all the elements but nothing seems to be working. I am fairly new to C# so I am sure Im missing something simple or doing something completely wrong. ;-)

Does this make any sense?

The XML tree looks like this:

C#

<Activities>
  <Activity>
    <ActivityName>Projekt</ActivityName>
    <ProjectNr>001</ProjectNr>
  </Activity>
  <Activity>
    <ActivityName>Absence</ActivityName>
    <ProjectNr>000</ProjectNr>
  </Activity>
</Activities>

Code in Controller:

C#

public ActionResult NewActivity()
{
   XElement xelement = XElement.Load(Server.MapPath("/App_Data/ActivitiesData.xml"));
   IEnumerable<XElement> Activity = xelement.Elements();

   foreach (var ProjNrList in Activity)
   {
      List<string> list = new List<string>();
      list.Add(ProjNrList.Element("ProjectNr").Value);

      ViewBag.ProjNrList = list;
      continue;
   }
   return View();
}

What I have tried:

I think I have tried everything, but obviously I have not. ;-)
I have tried multible loops, linq, readXML and many different ways of retrieving the list. Do not know what to try next. :-(

Posted 12-Apr-17 0:19am

Member 13123379

Updated 12-Apr-17 2:23am

Add a Solution

Comments

CHill60 12-Apr-17 6:39am

Try moving everything other than the update to the list outside of the loop i.e.

List<string> list = new List<string>();
foreach (var ProjNrList in Activity)
{
   list.Add(ProjNrList.Element("ProjectNr").Value);
}
ViewBag.ProjNrList = list;
return View();

Member 13123379 12-Apr-17 8:22am

Thank you so much! I knew it was something simple... ;-) It works now.

[no name] 12-Apr-17 8:11am

You are getting only last record because in for loop you are creating List<string> list = new List<string>(); every time you iterate.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 13123379 · Accepted Answer · 2017-04-12T02:22:00

Solution 1

That's what the problem was and I know why I got tricked by it too since I have tried to have things outside the loop, but not exactly the way you did it. ;-)
Great! Thanks!

C#

<pre>List<string> list = new List<string>();
foreach (var ProjNrList in Activity)
{
   list.Add(ProjNrList.Element("ProjectNr").Value);
}
ViewBag.ProjNrList = list;
return View();

Posted 12-Apr-17 2:22am

Member 13123379

Comments

CHill60 12-Apr-17 8:33am

You might have given me the opportunity to post the solution. Next time let the member who helps you in the comments post the solution that works.

Member 13123379 12-Apr-17 8:37am

So sorry! Thought I was supposed to do that. My appologies. Won't happen again. :-)