Empty structure is been written to file, want to know if I am writing the strucutre correctly.

Question

0.00/5 (No votes)

See more:

empty structure is been written to file as it gives blank spaces when I try to display its contents.

What I have tried:

void writetickets()//second function called after the addcache func
{
	string park1 = "Sign Sammoric/Tickets/";
	park1 += to_string(dat.year()) + "/" + to_string(dat.month()) + "/" + to_string(dat.day());
	if (!is_directory(park1.c_str()))//checks to see if the directory to write file to exists
	{

		if (create_directories(park1.c_str()))//create the directories
		{
			park1.append("/Tickets.dat");
			ofstream file(park1.c_str(), ios::out | ios::app | ios::binary);//opens the file in binary mode
			materials t1;
			if (file.is_open())//checksto se if the file is opened before fany furthe operations
			{
				auto r = material.begin();
				for (r = material.begin();r != material.end();r++)//iterates through the vector container
				{
					file.write((char *)&r, sizeof r);
				}
				file.close();
			}

		}
	}
	else
	{
		park1 += "/Tickets.dat";
		materials t1;
		ofstream file(park1.c_str(), ios::out | ios::app | ios::binary);
		if (file.is_open())
		{
			auto r = material.begin();
			for (r = material.begin();r != material.end();r++)
			{
				file.write((char *)&r, sizeof(r));
			}
			file.close();
		}
	}
}
void addcache()//function used to add to the vector<materials> container also the first func called
{
	materials t1;
	dat = QDate::currentDate();
	strncpy(t1.name1, pickapark->currentText().toStdString().c_str(), 30);
	strncpy(t1.ticketid, edit2->displayText().toStdString().c_str(), 10);
	strncpy(t1.serial, edit1->displayText().toStdString().c_str(), 10);
	l = dat.toString().toStdString();
	strncpy(t1.date, l.c_str(), 15);
	t1.y = day1->currentText().toInt();
	t1.check = 1;
	material.push_back(t1);
}
void viewtickets()
{
	string par = "Sign Sammoric/Tickets/" + to_string(boyear->currentText().toInt()) + "/" + to_string(setmonth1(bomonth->currentText())) + "/" + to_string(boday->currentText().toInt());
	if (is_directory(par.c_str()))
	{
		materials t1;
		par.append("/Tickets.dat");
		ifstream file;
		if (!material.empty());
		material.erase(material.begin(), material.end());
		file.open(par.c_str(), ios::in | ios::binary);
		if (file.is_open())
		{
			while (file.read((char *)&t1, sizeof(t1)))
				material.push_back(t1);
		}
		file.close();
	}
}

Posted 6-Apr-17 5:41am

Osikwemen

Updated 7-Apr-17 5:51am

v6

Add a Solution

Comments

Kevin Marois 6-Apr-17 11:49am

So what's your question?

Osikwemen 6-Apr-17 11:52am

want to know if the structure is been written correctly and with all its contents to the file.

[no name] 6-Apr-17 18:47pm

This is what programming is all about. You are in the drivers seat not us.
1. Learn to use your debugger and make sure the writes are occurring as you expect.
2. Download a hex file reader and check the contents of your resulting file yourself.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Answer 1 · 2017-04-06T06:16:00

Only you can check if it is written correctly. We only see some code which is not enough to gave you a meaningful answer. Especially, because you did not show the code that writes to a file.

However, there are some code lines that make it rather unlikely that the code is doing what you expect:

t1.y = b4->displayText().toInt();
if (isdigit(t1.y))

Used multiple times. t1.y is probably an int (because you assign the return value of toInt()). But isdigit() checks if the passed character (treated as int) is a digit. This will be true for values from 0x30 tro 0x39 ('0' to '9'). So the condition is met when the b4->displayText() string contains "48" to "57". That is probably not what you want.

if (!material.empty());

Does not harm but is just doing nothing.

Osikwemen · Answer 2 · 2017-04-07T05:51:00

void writetickets()
{
	string park1 = "Sign Sammoric/Tickets/";
	park1 += to_string(dat.year()) + "/" + to_string(dat.month()) + "/" + to_string(dat.day());
	if (!is_directory(park1.c_str()))//checks to see if the directory to write file to exists
	{

		if (create_directories(park1.c_str()))//create the directories
		{
			park1.append("/Tickets.dat");
			ofstream file(park1.c_str(), ios::out | ios::app | ios::binary);//opens the file in binary mode
			materials t1;
			if (file.is_open())//checksto se if the file is opened before fany furthe operations
			{
				auto r = material.begin();
				for (r = material.begin();r != material.end();r++)//iterates through the vector container
				{
					file.write(reinterpret_cast<char *>(&(*r).name1), sizeof((*r).name1));
					file.write(reinterpret_cast<char *>(&(*r).ticketid), sizeof((*r).ticketid));
					file.write(reinterpret_cast<char *>(&(*r).serial), sizeof((*r).serial));
					file.write(reinterpret_cast<char *>(&(*r).date), sizeof((*r).date));
					file.write(reinterpret_cast<char *>(&(*r).y), sizeof((*r).y));
					file.write(reinterpret_cast<char *>(&(*r).check), sizeof((*r).check));
				}
				file.close();
			}

		}
	}
	else
	{
		park1 += "/Tickets.dat";
		materials t1;
		ofstream file(park1.c_str(), ios::out | ios::app | ios::binary);
		if (file.is_open())
		{
			auto r = material.begin();
			for (r = material.begin();r != material.end();r++)
			{
				file.write((char *)&r, sizeof(r));
			}
			file.close();
		}
	}
}
void addcache()
{
	materials t1;
	dat = QDate::currentDate();
	strncpy(t1.name1, pickapark->currentText().toStdString().c_str(), 30);
	strncpy(t1.ticketid, edit2->displayText().toStdString().c_str(), 10);
	strncpy(t1.serial, edit1->displayText().toStdString().c_str(), 10);
	l = dat.toString().toStdString();
	strncpy(t1.date, l.c_str(), 15);
	t1.y = day1->currentText().toInt();
	t1.check = 1;
	material.push_back(t1);
}
void viewtickets()
{
	string par = "Sign Sammoric/Tickets/" + to_string(boyear->currentText().toInt()) + "/" + to_string(setmonth1(bomonth->currentText())) + "/" + to_string(boday->currentText().toInt());
	if (is_directory(par.c_str()))
	{
		materials t1;
		par.append("/Tickets.dat");
		ifstream file;
		if (!material.empty());
		material.erase(material.begin(), material.end());
		file.open(par.c_str(), ios::in | ios::binary);
		if (file.is_open())
		{
			while (!file.fail())
			{
				file.read(reinterpret_cast<char *>(&t1.name1), sizeof(t1.name1));
				file.read(reinterpret_cast<char *>(&t1.ticketid), sizeof(t1.ticketid));
				file.read(reinterpret_cast<char *>(&t1.serial), sizeof(t1.serial));
				file.read(reinterpret_cast<char *>(&t1.date), sizeof(t1.date));
				file.read(reinterpret_cast<char *>(&t1.y), sizeof(t1.y));
				file.read(reinterpret_cast<char *>(&t1.check), sizeof(t1.check));
				material.push_back(t1);
			}
				
		}
		file.close();
	}
}

Empty structure is been written to file, want to know if I am writing the strucutre correctly.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0