Unable to detect that the bat file is running or not. Or even if it is getting readed?

Question

0.00/5 (No votes)

See more:

public partial class Service1 : ServiceBase
    {
        private Timer timer1 = null;

        public Service1()
        {
            InitializeComponent();
        }

        protected override void OnStart(string[] args)
        {
            timer1 = new Timer();
            this.timer1.Interval = 60000; //60 sec
            this.timer1.Elapsed +=new System.Timers.ElapsedEventHandler(this.timer1_Tick);
            timer1.Enabled=true;
            Library.WriteErrorLog("test windows service started");
            
        }

        private void timer1_Tick(object sender, ElapsedEventArgs e)
        {
            

            Process proc = null;
            try
            {
                string batrun = string.Format("cmd.exe","/c" + @"C:\Abhay\batfile");
                proc = new Process();
                proc.StartInfo.WorkingDirectory = batrun;
                proc.StartInfo.FileName = "webupknvp";
                proc.StartInfo.CreateNoWindow = false;
                proc.Start();
                proc.WaitForExit();
                
                
              

            }
            catch (Exception ex)
            {
                Console.WriteLine(ex.StackTrace.ToString());
            }
            Library.WriteErrorLog("timer ticked and batch file executed");

        }

        protected override void OnStop()
        {
            timer1.Enabled = false;
            Library.WriteErrorLog("Test Service ended");
        }

What I have tried:

We are stuck here still searching a possible way!!.

Posted 9-Mar-17 20:12pm

r.abhaysinghania

Updated 9-Mar-17 20:38pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Graeme_Grant · Accepted Answer · 2017-03-09T20:38:00

After

C#

p.WaitForExit();

Don't forget to check its return value to make sure it actually was successful:

C#

if(p.ExitCode == 0) { // Or whatever return code you're expecting
    //...
}

If you are still having problems, move the code to its own function and run manually:

C#

private int RunProcess(string workDir, string appName, string args, bool hide = false)
{
	string batrun = string.Format("cmd.exe","/c" + @"C:\Abhay\batfile");
	proc = new Process();
	proc.StartInfo.WorkingDirectory = workDir;
	proc.StartInfo.FileName = appName;
	proc.StartInfo.Arguments = args
	proc.StartInfo.CreateNoWindow = hide;
	
	proc.Start();
	proc.WaitForExit();
	
	return p.ExitCode
}

Then testing and using from your timer event becomes very easy:

C#

var result = RunProcess("c:\", "file.Bat", "", false);
if (result == 0)
{
	// success
}
else
{
	// failed ErrorLevel / app ExitCode
}