Update query not executed properly

Question

1.00/5 (1 vote)

See more:

Hi all,

Iam doing one task where i want to executed update query i have table name is Medicine_Available_Detail here iam storing total medicine available column name is Availability,I have one datagridview where im putting Quantity of that Medicine after user enter Quantity of particular medicine then it table update as Availability-Quantity for that medicine i written a code but its not executed

What I have tried:

C#

int quantity = Convert.ToInt16(dataGridView1.Rows[e.RowIndex].Cells["Quantity"].Value);

                            cmd = new OleDbCommand(@"update Medicine_Available_Detail set [Availability]=[Availability]-@Quantity where Medicine_Name=@Medicine_Name", con);
                            cmd.Parameters.AddWithValue("@Quantity", quantity);
                            cmd.Parameters.AddWithValue("@Medicine_Name", medicinename);

con.Open();
                            int n = cmd.ExecuteNonQuery();
                            con.Close();
                            MessageBox.Show("Record Updated Successfully");

Posted 16-Feb-17 5:34am

Atul Rokade

Updated 19-Feb-17 6:54am

Add a Solution

Comments

Richard MacCutchan 16-Feb-17 11:42am

Why are you displaying "Record Updated Successfully" when you have no idea whether it succeeded or not?

Atul Rokade 16-Feb-17 12:12pm

for testing purpose i done but previously code was executed as expect but now not understand where i done mistake

Richard MacCutchan 16-Feb-17 12:20pm

Sorry, but we cannot guess why it is not working. Do not post messages like that as they are just a waste of time. Add some proper error checking into your code and use your debugger to find out exactly what is happening.

Atul Rokade 16-Feb-17 12:28pm

Sorry im waste your precious time i will check and post as answer as soon as sorry once again

Richard MacCutchan 16-Feb-17 13:44pm

No, you are wasting your time.

Putting code like that in order to test your application is just a bad idea. The whole point of testing is to find errors in your code. So if you ignore errors in the testing they just sit there waiting for product release, at which time they cause absolute chaos.

[no name] 16-Feb-17 11:44am

What do you mean "its not executed"?
Parameters in Access are substituted by ? in the query string
Why are you showing a "success" message when you didn't check whether is was actually successful?

Richard MacCutchan 16-Feb-17 12:22pm

Wish I had a £1 for every time I have seen people do that.

[no name] 16-Feb-17 13:02pm

Wish I had one for every "not working" we have seen in here.

Karthik_Mahalingam 16-Feb-17 22:37pm

what is the error message

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Asmita Bhurke · Answer 1 · 2017-02-16T22:28:00

First of all, to know if any row is updated or not, check value of your variable

if it is 0 means no record is matching the criteria you are defining for update.
So check the value of varible

medicinename

in your table exists on not.

This is all can your suggest by looking at your code.

Atul Rokade · Answer 2 · 2017-02-19T06:54:00

Hi here is find solution i use two cmd.ExecuteNonQuery();its working fine for me ,dataGridView1_RowLeave event i written 3 insert query and one update query and only one ExecuteNonQuery instead using one Execute non query i written two seprate ExecuteNonQuery with different variable

C#

  cmd = new OleDbCommand("update Medicine_Available_Detail set [Availability]=[Availability]-@Quantity where [Medicine_Name]=@Medicine_Name", con);
                            cmd.Parameters.AddWithValue("@Quantity", quantity);
                            cmd.Parameters.AddWithValue("@Medicine_Name", medicinename);
con.Open();

                            int n1 = cmd.ExecuteNonQuery();
con.Close();

Update query not executed properly

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0