Getting this error with the following query in SQL server 2014

Question

0.00/5 (No votes)

See more:

SQL-Server-2014

I have buttons "UPDATE" and "DELETE". They have the same errors...

An expression of non-boolean type specified in a context where a condition is expected, near 'ID'.

What I have tried:

VB

Private Sub btnUpdate_Click(sender As Object, e As EventArgs) Handles btnUpdate.Click
        Try
            conn = New SqlConnection(strcon)
            conn.Open()
            Dim str As String = "Update PatientInfo set Surname=@Surname,Firstname=@Firstname,MI=@MI,Gender=@Gender,Birthday=@Birthday,Address=@Address,Contact=@Contact,Email=@Email Where Patient ID=@PID"
            cmd = New SqlCommand(str, conn)
            cmd.Parameters.AddWithValue("@Surname", txtSurname.Text)
            cmd.Parameters.AddWithValue("@Firstname", txtFirstname.Text)
            cmd.Parameters.AddWithValue("@MI", txtMI.Text)
            cmd.Parameters.AddWithValue("@Gender", CmbxGender.Text)
            cmd.Parameters.AddWithValue("@Birthday", dtpBday.Text)
            cmd.Parameters.AddWithValue("@Address", txtAdd.Text)
            cmd.Parameters.AddWithValue("@Contact", txtContact.Text)
            cmd.Parameters.AddWithValue("@Email", txtEmail.Text)
            cmd.Parameters.AddWithValue("@PID", txtPID.Text)
            cmd.ExecuteNonQuery()
            MessageBox.Show("Data has been updated!")
            loadData()
            cmd.Dispose()
            conn.Close()

        Catch ex As Exception
            MessageBox.Show(ex.Message)
        End Try
    End Sub
'==========================================================================

Private Sub btnDelete_Click(sender As Object, e As EventArgs) Handles btnDelete.Click

        Dim cmd As New SqlCommand
        Try

            conn.ConnectionString = strcon
            conn.Open()
            cmd.Connection = conn
            cmd.CommandText = "Delete from PatientInfo Where Patient ID=" + txtPID.Text
            cmd.ExecuteNonQuery()
            MessageBox.Show("Data has been deleted")
            loadData()

            conn.Close()


        Catch ex As Exception
            MessageBox.Show(ex.Message)
        End Try
    End Sub

Posted 17-Jan-17 12:05pm

Member 12905345

Updated 17-Jan-17 13:52pm

Add a Solution

Comments

[no name] 17-Jan-17 18:41pm

Try [Patient ID]=@PID

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2017-01-17T13:52:00

It's a bad idea to have space characters in table and column names. In your SQL query you apparently have a column called "Patient ID". It should probably be "PatientID", but if you insist on keeping this column name with a space in it you MUST specify the column name in all SQL statements with square brackets:

DELETE FROM PatientInfo WHERE [Patient ID]=@PID"

Oh, and just because you only have one parameter in the DELETE query, that does NOT mean you can get away with string concatenating the Id on the end of the query. ALWAYS, ALWAYS, ALWAYS use parameterized queries, even if you're only using one parameter.