The conversion of the nvarchar value '3391569654' overflowed an int column. The statement has been terminated.

Question

0.00/5 (No votes)

See more:

, +

C#

     protected void btnEdit_Click(object sender, EventArgs e)
        {
            try
            {   SqlConnection mysqlconection = new SqlConnection(myconect);
                SqlDataAdapter myadp = new SqlDataAdapter();
                myadp.UpdateCommand = new SqlCommand("Update [tbl_CustInfo] Set [mydate]=@mydate,[name]=@name,[idnasb]=@idnasb,[iddevice]=@iddevice,[email]=@email,[mobile]=@mobile,[tel]=@tel,[Adress]=@Adress WHERE [codemeli]=" + txtcodemeli.Text, mysqlconection);
                mydat = dryear.SelectedItem.Value.ToString() + "/" + drmonth.SelectedItem.Value.ToString() + "/" + drday.SelectedItem.Value.ToString();
                myadp.UpdateCommand.Parameters.Add("@mydate", SqlDbType.NVarChar, 15).Value = mydat;
                myadp.UpdateCommand.Parameters.Add("@name", SqlDbType.NVarChar, 100).Value = txtname.Text;
                myadp.UpdateCommand.Parameters.Add("@idnasb", SqlDbType.Int).Value = dridnasb.SelectedIndex;
                myadp.UpdateCommand.Parameters.Add("@iddevice", SqlDbType.Int).Value = drdevice.SelectedIndex;
                myadp.UpdateCommand.Parameters.Add("@email", SqlDbType.NVarChar, 50).Value = txtemail.Text.ToString();
                myadp.UpdateCommand.Parameters.Add("@mobile", SqlDbType.NVarChar, 11).Value = txtmobile.Text.ToString();
                myadp.UpdateCommand.Parameters.Add("@tel", SqlDbType.NVarChar, 11).Value = txttel.Text.ToString();
                myadp.UpdateCommand.Parameters.Add("@adress", SqlDbType.NVarChar, 250).Value = txtAdress.Text;
                myadp.UpdateCommand.Connection = mysqlconection;
                mysqlconection.Open();
                myadp.UpdateCommand.ExecuteNonQuery();
                mysqlconection.Close();                
            }
            catch (Exception ex)
            {
                errorLabel.Text = ex.Message;
                errorLabel.Visible = true;
            }
        }

What I have tried:

// when click edit Button i see above error message
// can you  tell me what is problem

Posted 26-Nov-16 3:50am

moj1978

Updated 26-Nov-16 7:57am

Add a Solution

Comments

moj1978 26-Nov-16 11:52am

i have a id that is primary key
and one field "codemeli" that it is not primary key but it is Unique
i search in this table with field "codemeli"
is it true?

Philippe Mori 28-Nov-16 9:42am

What is the column definition of codemeli in the database? And as suggested by someone, use parametrised query parameter for that parameter too.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2016-11-26T04:10:00

Solution 1

Well... that's because an int is a signed 32-bit value with a range of -2,147,483,648 to 2,147,483,647. Values outside that range cannot be held in a int.
Use an unsigned integer or uint (0 to 4,294,967,295), or consider changing to a long (-9,223,372,036,854,775,808 to 9,223,372,036,854,775,807)

And do yourself a favour: you clearly know about parameterised queries and SQL Injection, so why use string concatenation as well? Even the one instance you have in your code leaves you wide open to having your database damaged or destroyed...

Posted 26-Nov-16 4:10am

OriginalGriff

Updated 26-Nov-16 4:12am

v2

Comments

moj1978 26-Nov-16 11:45am

you can see this two item is int and fill with droppdownlist.SelectedIndex
this program don't need integer or uint
-----------------------------------------------------------
myadp.UpdateCommand.Parameters.Add("@idnasb", SqlDbType.Int).Value = dridnasb.SelectedIndex;
myadp.UpdateCommand.Parameters.Add("@iddevice", SqlDbType.Int).Value = drdevice.SelectedIndex;
----------------------------------------------------
can you help me?

OriginalGriff 26-Nov-16 11:51am

Your error message is very explicit: you are passing a string value to SQL which it is trying to convert to an integer value. That string contains "339159654" which exceeds the value you can fit into an integer, so SQL complains.
Which value? Don't know - that's up to you and your data.
But...if it's a SelectedIndex I'd be amazed: you would need a drop down list or similar control with over 3,000,000,000 items in it - which would be patently ludicrous.
Use the debugger, look at your data. We can't!