Dynamic label text within a for loop

Question

0.00/5 (No votes)

See more:

i am using web forms

C#

I made a simple WF in C# in an attempt to change the label dynamically.

However, when I run this code, there is no visible change, until after the code has run, and then it changes to "Processing 9" 0-8 are not ever shown. Is it because it is within the loop?

What I have tried:

C#

private void button1_Click(object sender, EventArgs e)
   {
       for (int i = 0; i < 10; i++)
       {
           label9.Text = "Processing " + i.ToString();
           Thread.Sleep(1000);
       }
   }

Posted 28-Oct-16 21:16pm

Merajuddin Ansari

Updated 2-Nov-16 18:47pm

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-10-28T21:42:00

The problem is that you are running that code on the UI thread - because if you weren't you would get an "cross threading error" - which means that the code that is responsible for updating your display cannot run until that method exits. Because it doesn't exit but goes to sleep instead, it isn't running to update the display, so you never see the number change.

There are ways to get what you want - i.e. the label changing every second - but exactly how you do it depends on the environment you are working in: a WinForms solution would be different to a website based solution for example. And there are different ways to do it, depending on how complicated you can cope with, and how much bad code you can tolerate.
I'm going to assume a WinForms solution, and since you are a beginner, I'm going to ignore the "bad code" option as well, for reasons it would take far too long to explain.
That leave you two options:
1) Multi-threading.
2) Timer.

The threading option gets very complicated, because you need to create a new thread, and then pass some code back to the original thread to actually change the label (or you get the cross threading error I mentioned earlier) so I'm going to put that on the shelf as well, and explain the simplest "proper" way to do it.

Delete your loop.
Create a class level integer, called count.

C#

private int count = 0;

Add a Class level Timer instance, called updateLabel

C#

private System.Windows.Forms.Timer updateLabel = new System.Windows.Forms.Timer();

In your Click event, add this code:

C#

updateLabel.Interval = 1000;
updateLabel.Tick += updateLabel_Tick;
updateLabel.Start();

Now add a handler for the Tick event:

C#

void updateLabel_Tick(object sender, EventArgs e)
    {
    label1.Text = "Processing " + (++count).ToString();
    }

Run your code.

Karthik_Mahalingam · Answer 2 · 2016-11-02T18:43:00

try using Window setInterval() Method[^]

HTML

<html xmlns="http://www.w3.org/1999/xhtml">
<head runat="server">
    <title></title>
    <script>
        function doProcess() {
            var i = 0;
            var interval = window.setInterval(function () {
                document.getElementById('<%=lbl.ClientID%>').textContent = "Processing " +  i;
               i++;
               if (i >= 10)
                   clearInterval(interval);
           }, 1000);
       }

    </script>
</head>
<body>
    <form id="form1" runat="server">
        <asp:Label Text="" ID="lbl" runat="server" />
        <asp:Button Text="Submit" OnClientClick="doProcess();return false;" runat="server" />
    </form>
</body>
</html>

Dynamic label text within a for loop

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0