Is this a correct way using BackgroundWorker?

Question

5.00/5 (1 vote)

See more:

Hi, I am new to threading. I would like to know if this a correct way to quickly run a function on a separate thread? Any bad issue or possible errors? Thanks

C#

public static void InvokeAsync<TParam, TResult>(Func<TParam, TResult> function, TParam parameter, Action<TResult> completedAction)
{
     BackgroundWorker bw = new BackgroundWorker();
     bw.DoWork += (sender, e) => e.Result = function(parameter);
     bw.RunWorkerCompleted += (sender, e) => completedAction((TResult)e.Result);
     bw.RunWorkerAsync();
}

Posted 3-Oct-10 4:37am

Ibrahim Yusuf

Add a Solution

Comments

M. Mohsen 3-Oct-10 18:28pm

Does this actually work ??

Ibrahim Yusuf 3-Oct-10 21:45pm

Yes it compiled successfully. I tested it to process value types like string or int, no problem. But I am not sure if this is the correct way to do it - especially on reference types, collection types or thread-safe types.

aidin Tajadod 3-Oct-10 23:56pm

Why did you make it so complicated?

Ibrahim Yusuf 4-Oct-10 10:58am

No I didn't, I was just simplified it using generics, anonymous method and lambda expression, instead of writing 2 separate event handler.

M. Mohsen 4-Oct-10 15:21pm

I think you might be interested in reading about delegates in C#. I believe you can write a simpler code :).

2 solutions

Solution 1

I recommend you read the articles on BackgroundWorker here[^] and here[^].

Posted 5-Oct-10 9:11am

BillW33

Comments

Ibrahim Yusuf 9-Oct-10 9:58am

Thank you ^^

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Chris Trelawny-Ross · Accepted Answer · 2010-10-05T10:38:00

Ibrahim, your sample code is correct - but strictly has nothing to do with threading.

As you pointed out, really what you're doing is wrapping the work that subscribes to the two events, and then starts the background worker. And all of that has nothing to do with what you may be doing on the background thread (the body of function) and how it interacts with memory on the invoking thread.

And, your tests proved that InvokeAsync does indeed cause a thread to do the assigned work and then report its completion status (or, at least, I assume your tests demonstrate that).

As well as the links CIDev provided, I would read and understand about:
* deadlocks (which happen when two or more threads are each waiting on locks owned by the other threads),
* what it means for code to be thread-safe and what practices and
* what technologies are available to ensure that your code is thread-safe.