Saving when closing a document

Question

5.00/5 (1 vote)

See more:

I have an MDI application. When I close a document, how am I supposed to implement saving the document if it is dirty? Do I use SetModifiedFlag() and then call the file dialog directly or is it supposed to happen automatically somehow?

I'm confused because using the menu item produces the save and save-as dialog automatically, but closing and marking the doc as dirty doesn't bring up the save or save-as dialog. What am I supposed to do here?

I'm not sure if this makes a difference but I'm overriding OnSaveDocument( LPCTSTR lpszPathName ) and using std::ofstream to output the file.

Posted 30-Sep-10 1:20am

Brian Bennett

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Aamir Butt · Accepted Answer · 2010-09-30T01:25:00

Solution 1

You have to set the modified flag by calling SetModifiedFlag() and this will be your logic that at which places you want to call it. Rest will be handled by MFC automatically. However, you will have to write the serialization/deserialization code to save the file properly.

Posted 30-Sep-10 1:25am

Aamir Butt

Comments

Brian Bennett 30-Sep-10 7:48am

Thanks, Aamir. That was fast! I had tried setting that flag in OnCloseDocument() but I guess it was too late at that point. So I tested it in View::Draw() instead and it worked. Thanks for the help.

krmed · Accepted Answer · 2010-09-30T04:10:00

Solution 2

Instead of overriding OnSaveDocument, you should put your code in the Serialze method of the document class. The default Serialize method has

SQL

if (ar.IsStoring())
{
    ...
}
else
{
    ....
}

Just put your code to save/load in the correct part of the if/else.

Hope that helps.

Posted 30-Sep-10 4:10am

krmed

Comments

Brian Bennett 2-Oct-10 4:22am

I tend to want to believe you but it would have been nice to hear why this would make a difference? Can't wait to hear the benefits. Thank you.

krmed · Accepted Answer · 2010-10-02T03:09:00

Solution 3

Using the Serialize method allows the framework to handle the saving of your document in a standard way, meaning you don't have to override the OnFileSave. Additionally, when you try to open the document, Serialize is called again, thus you can open the existing data without also overriding OnFileOpen.

Using Serialize is the proper MFC way to save/load documents, and the framework takes care of the basics.

Posted 2-Oct-10 3:09am

krmed

Comments

Brian Bennett 2-Oct-10 18:18pm

That's kind of cool. I'll assume it's OK to still use std::ofstream inside the Serialize function even though it's not mfc. What is it, CArchive object that mfc uses? Thank you, it really helps to know how things are supposed to be done.

krmed 2-Oct-10 18:24pm

Yes, of course you can use ofstream (or anything else you want to). MFC provides the CArchive for your use - but you don't have to.