Cmd skips if-statement?

Question

0.00/5 (No votes)

See more:

I was bored so I tried to make a virtual console inside CMD and it appears to be working fine up until the point of checking the input and executing a command accordingly.

I get a screen that says ": " and there you can type what command you want to execute, and typing works fine but when it goes to check what command to execute, problems occurr.

The problem is if I type "register" which should go to a label called :reg, I execute the "exit" command, which should only be executed when I type "exit".

Here's my script:

echo off
cls

:console
title Command prompt
cls
set /p c=": "

if "%c%"=="exit"
(
exit
)

if "%c%"=="register"
(

goto :reg

)


:reg
title Register a new account
cls
echo Registration
echo.

set /p newName="Username: "
set /p newPass="Password: "
cls
echo Processing...
>nul timeout /t 3
goto console

What I have tried:

I've tried changing the order of the commands and if-statements but it appears that the first command always gets executed no matter what you type.

Posted 11-Oct-16 2:00am

Member 12787419

Updated 11-Oct-16 5:18am

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Michael_Davies · Answer 1 · 2016-10-11T02:39:00

Try this, stuck pauses in and echo to verify:

cls
 
:console
title Command prompt
cls
set /p c=": "
echo %c%
pause

if "%c%"=="exit" goto end
 
if "%c%"=="register" goto reg

pause 

:reg
title Register a new account
cls
echo Registration
echo.
 
set /p newName="Username: "
set /p newPass="Password: "
cls
echo Processing...
>nul timeout /t 3
goto console
:end

Member 12641199 · Answer 2 · 2016-10-11T04:25:00

Remove the quotes from everything and there's no need for brakets

echo off
cls
 
:console
title Command prompt
cls
set /p c=: 
 
if %c%==exit exit
 
if %c%==register goto :reg

 
:reg
title Register a new account
cls
echo Registration
echo.
 
set /p newName="Username: "
set /p newPass="Password: "
cls
echo Processing...
>nul timeout /t 3
goto console

Patrice T · Answer 3 · 2016-10-11T05:08:00

Solution 3

Where did you catch that if is multi line ? and with () ?
Here is a link for the syntax:
More Powerful Batch Files- Branching with "If" statements[^]

Windows Command Line |Shell List and Reference[^]

Posted 11-Oct-16 5:08am

Patrice T

Richard MacCutchan · Answer 4 · 2016-10-11T05:18:00

Solution 4

if "%c%"=="register"
(
goto :reg 
)

:reg

See anything wrong there? If the user does not type exit, then anything else will go to the :reg label. Make your subroutines into proper subroutines by using call not goto.

Posted 11-Oct-16 5:18am

Richard MacCutchan

Cmd skips if-statement?

4 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0