I have facing a issue in database but I dont know why

Question

1.00/5 (1 vote)

See more:

C#

Hello Guys, am facing a little issue i got an error no value given for one or more required parameters.

What I have tried:

DataSet dsa = new DataSet();
            DataTable dt = new DataTable();
            dsa.Tables.Add(dt);
            OleDbDataAdapter da = new OleDbDataAdapter();
            da = new OleDbDataAdapter("SELECT [Flavours],COUNT(Flavours)As[asdf] From [Total] Where [Dates] >= #" + dateTimePicker1.Value.ToString("dd/MM/yyyy") + "# AND [Dates] <= #" + dateTimePicker2.Value.ToString("dd/MM/yyyy") + "# Group By [Flavours]", VCON);
            da.Fill(dt);
            dataGridView1.DataSource = dt;
            VCON.Close();

Posted 26-Sep-16 22:58pm

Member 9983063

Updated 27-Sep-16 1:17am

Add a Solution

Comments

F-ES Sitecore 27-Sep-16 5:52am

If this is an Access database you can get this issue if you're referring to something that doesn't exist, like a fieldname or table (either it doesn't exist or maybe you have misspelled it). It assumes the non-existent entity you are referring to is a parameter so expects you to supply it.

Start with a more basic query and add to it until you hit the issue, so start with just

select * from [Total]

then

select [Flavours] from [Total]

and so on.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-09-26T23:21:00

Stop using string concatenation to pass values - use a parameterised query instead:

C#

OleDbDataAdapter da = new OleDbDataAdapter();
da = new OleDbDataAdapter("SELECT [Flavours],COUNT(Flavours)As[asdf] From [Total] Where [Dates] BETWEEN ? AND  ? Group By [Flavours]", VCON);
da.SelectCommand.Parameters.AddWithValue("?", dateTimePicker1.Value);
da.SelectCommand.Parameters.AddWithValue("?", dateTimePicker2.Value);
da.Fill(dt);

If you are habitually using string concatenation, then be aware that your database is at risk for SQL Injection, where a user can destroy it just by typing in text boxes: xkcd: Exploits of a Mom[^]
Always use parameterised queries.

Harpreet05Kaur · Answer 2 · 2016-09-26T23:28:00

Solution 2

Hi,
Your string containing query is not correct. Try pass values through parameters.

Posted 26-Sep-16 23:28pm

Harpreet05Kaur

Comments

Member 9983063 27-Sep-16 5:31am

am using this query but i have still get an error like that no value given for one or more required parameters.

Member 9983063 27-Sep-16 5:31am

OleDbDataAdapter da = new OleDbDataAdapter();
da = new OleDbDataAdapter("SELECT [Flavours],COUNT(Flavours)As[asdf] From [Total] Where [Dates] BETWEEN ? AND ? Group By [Flavours]", VCON);
da.SelectCommand.Parameters.AddWithValue("?", dateTimePicker1.Value);
da.SelectCommand.Parameters.AddWithValue("?", dateTimePicker2.Value);
da.Fill(dt);

Harpreet05Kaur · Answer 3 · 2016-09-27T01:17:00

OleDbDataAdapter da = new OleDbDataAdapter();
da = new OleDbDataAdapter("SELECT [Flavours],COUNT(Flavours)As[asdf] From [Total] Where [Dates] BETWEEN Columnname1 AND Columnname2 Group By [Flavours]", VCON);
da.SelectCommand.Parameters.AddWithValue("@Columnname1", dateTimePicker1.Value);
da.SelectCommand.Parameters.AddWithValue("@Columnname1", dateTimePicker2.Value);
da.Fill(dt);

Where @Columnname / @Parametername is same as in database.
also you can convert dateTimePicker1.Value to string or datetime as required in database side

I have facing a issue in database but I dont know why

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0