Inputted string parsed gives in wrong result

Question

1.00/5 (1 vote)

See more:

C++

#include<stdio.h>
#include<string.h>
main()
{
	char* newme(char* input1);
	char newi[100],data[100]="10,10,50,120,20,30,10,140,205";
	strcpy(newi,newme(data));
	printf("%s");
	return 0;
}
char* newme(char* input1)
{
	int Data[20],i=0;
	float A,B,C,D,E,F,G,H,I;
	char seps[]=",";
	char* token;
	char input2[25];
	strcpy(input2,input1);
	printf("%s",input2);
	token=strtok(input2,seps);
	while(token!=NULL)
	{
		Data[i]=atof(token);
		token=strtok(NULL,seps);
		i++;
		printf("%f",Data[i]);
	}
	printf("\n%d",i);
     A=Data[0];B=Data[1];C=Data[2];D=Data[3];E=Data[4];F=Data[5];G=Data[6];H=Data[7];I=Data[8];
	printf("\n data =%f %f %f %f %f %f %f %f %f",A,B,C,D,E,F,G,H,I);
	return input2;
}

The output must be same as the the input but instead it gives -1.#INDO for most of the values

What I have tried:

Increasing the buffer size, changing atof to atoi

Posted 8-Sep-16 20:53pm

Erebus_22

Updated 9-Sep-16 0:47am

v3

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2016-09-08T21:21:00

I post here the output of a modern compiler with the 'all warnings activated' option (namely gcc -Wall) invoked on your code:

foo.c:3:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
 main()
 ^
foo.c: In function ‘main’:
foo.c:8:9: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat=]
  printf("%s");
         ^
foo.c: In function ‘newme’:
foo.c:23:11: warning: implicit declaration of function ‘atof’ [-Wimplicit-function-declaration]
   Data[i]=atof(token);
           ^
foo.c:26:10: warning: format ‘%f’ expects argument of type ‘double’, but argument 2 has type ‘int’ [-Wformat=]
   printf("%f",Data[i]);
          ^
foo.c:30:9: warning: function returns address of local variable [-Wreturn-local-addr]
  return input2;
         ^
foo.c:29:2: warning: ‘I’ is used uninitialized in this function [-Wuninitialized]
  printf("\n data =%f %f %f %f %f %f %f %f %f",A,B,C,D,E,F,G,H,I);
  ^
foo.c:29:2: warning: ‘H’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘G’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘F’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘E’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘D’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘C’ is used uninitialized in this function [-Wuninitialized]

Now let's examine the above mess...

foo.c:3:1: warning: return type defaults to ‘int’ [-Wimplicit-int]
 main()
 ^

You should always specify the type of the return value of a C function (in this particular scenario you are lucky because the default, int, is correct).

foo.c: In function ‘main’:
foo.c:8:9: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat=]
  printf("%s");
         ^

You didn't provide the required argument (the string to print).

foo.c: In function ‘newme’:
foo.c:23:11: warning: implicit declaration of function ‘atof’ [-Wimplicit-function-declaration]
   Data[i]=atof(token);
           ^

You should include stdlib.h in order to use atof.

C#

foo.c:26:10: warning: format ‘%f’ expects argument of type ‘double’, but argument 2 has type ‘int’ [-Wformat=]
   printf("%f",Data[i]);
          ^

There is a mismatch between the format specifier and the type of the variable to printout (you usually have to either change the format specifier of the variable type).

foo.c:30:9: warning: function returns address of local variable [-Wreturn-local-addr]
  return input2;
         ^

This should make ring a bell very loud in your head, because it is usually the first sign of the incoming catastrophe: after function execution, a local variable does not exist any more.

C#

foo.c:29:2: warning: ‘I’ is used uninitialized in this function [-Wuninitialized]
  printf("\n data =%f %f %f %f %f %f %f %f %f",A,B,C,D,E,F,G,H,I);
  ^
foo.c:29:2: warning: ‘H’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘G’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘F’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘E’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘D’ is used uninitialized in this function [-Wuninitialized]
foo.c:29:2: warning: ‘C’ is used uninitialized in this function [-Wuninitialized]

Printing out uninitialized variables usually produces fancy results.

The bottom line is: the compiler is your friend, use it wisely.

Patrice T · Answer 2 · 2016-09-08T21:25:00

Try to replace

C++

i++;
printf("%f",Data[i]);

by

C++

printf("%f",Data[i]);
i++;

it may help

You should learn to use the debugger as soon as possible. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

The debugger allow you to follow the execution line by line, inspect variables and you will see that there is a point where it stop doing what you expect.
Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.
When the code don't do what is expected, you are close to a bug.

Inputted string parsed gives in wrong result

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0