How do I replace chars in a string?

Question

0.00/5 (No votes)

See more:

C++

string title = "I like to code."
char arr[title.size() + 1];
strcpy(arr, title.c_str());
int i = 0;
while(arr[1][i] != 0){
	if(arr[1][i] == ' '){
		arr[1][i] = '-';
	};
	i++;
};
string name(arr);
return name;

This is the code that I have mashed together. As you can see, I am converting a string into an array, going through the array char by char, replacing spaces with dashes as I go along, then converting the end result back into a string. The problem is that the compiler throws back 'error: invalid types for array subscript' for the 'while' statement and the two lines after it. How can I fix this? Thanks, all!

What I have tried:

I have tried using the std::replace template from #include <algorithm>, but to no avail.

Posted 19-Aug-16 6:47am

Anti-Antidote

Updated 19-Aug-16 7:05am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2016-08-19T07:05:00

Try to replace all arr[1][i] with arr[i] to make the compiler happy.

To track other bugs:
You should learn to use the debugger as soon as possible. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

The debugger allow you to follow the execution line by line, inspect variables and you will see that there is a point where it stop doing what you expect.
Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.
When the code don't do what is expected, you are close to a bug.