Static variable or static list problem ?

Question

0.00/5 (No votes)

See more:

Hello ,
I am using static list of string in my asp.net(C#) Code like

C#

private static List<string> newlist = new List<string>();

Now I have one textbox from which i am taking input string and adding in to list on button click like

C#

protected void Button1_Click(object sender, EventArgs e)
   {
       newlist.Add(TextBox1.Text);
       TextBox1.Text = "";

   }

And on another button click i am showing this list on literal control using foreach loop like this,

C#

protected void Button2_Click(object sender, EventArgs e)
    {
        ltrList.Text = "";
        foreach(var l in newlist)
        {
            ltrList.Text += l.ToString() + "<br/>";
        }
    }

I have host this page on server. When at a time to users access this webform and add items in list giving input from textbox the items show to eachother to both users.
Suppose one user add "Veeshal" and add to list and another user add "Amol" and add to list. And when they click on show, both users will get all items from list "Veeshal" and "Amol".
I think it's because of static. How to solve this problem. I don't want to show the list of items to each other.

What I have tried:

I have tried
protected void Button2_Click(object sender, EventArgs e)
{
ltrList.Text = "";
foreach(var l in newlist)
{
ltrList.Text += l.ToString() + "
";
}
}

Posted 17-Jul-16 5:56am

Veeshal Mali

Updated 17-Jul-16 18:51pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2016-07-17T06:09:00

Simple: don't use static.
The problem is that static variables are available to all instances of a class in an application - which for a web site can be (but may not be) a number of user sessions.
Instead, store your list in the Session - in your Page_Load you check if it exists, and retrieve it if it does. If it doesn't, you then create it. Either way, you store it as a class level instance variable, not static.
When you finish adding items to it, you put it back into the Session for next time.

Karthik_Mahalingam · Accepted Answer · 2016-07-17T18:51:00

In addition to above solution,

you shall do this in a simpler way using hidden field

create a hidden field control in aspx

ASP.NET

<asp:HiddenField ID="hdnfldList" runat="server" />

and you shall append the text from textbox to the literal control

C#

protected void Button1_Click(object sender, EventArgs e)
       {
            ltrList.Text += TextBox1.Text + "<br/>";
            TextBox1.Text = "";

       }

Static variable or static list problem ?

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0