Why is my C++ program crashing

Question

0.00/5 (No votes)

See more:

I am Learning how to use vectors in STL

I don't know why my program is crashing.

What I have tried:

#include <iostream>
#include<vector>
using namespace std;

int main()
{
    vector<int>vec(10);
    for(int i=0;i<10;i++)
    {
        vec.at(i)=i+1;
        //vec[i]=i+1;
    }
    for(vector<int>::iterator itr=vec.begin();itr!=vec.end();++itr)
    {
        cout << *itr << endl;
    }
    vector<int>::iterator itr1;
    *itr1=vec[4];//PUNGA!
    vec.erase(itr1);
    for(vector<int>::iterator itr=vec.begin();itr!=vec.end();++itr)
    {
        cout << *itr << endl;
    }
}

Posted 4-Jul-16 3:55am

Member 12566145

Updated 4-Jul-16 4:23am

Jochen Arndt

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Accepted Answer · 2016-07-04T04:23:00

You are accessing an unitialised variable (the iterator itr1) with the dereference operator (*).

To let the iterator point to a specific vector element add the index to the iterator pointing to the begin of the vector:

C++

itr1 = vec.begin() + 4;
vec.erase(itr1);

Alternatively use advance - C++ Reference[^]:

C++

itr1 = vec.begin();
std::advance(itr1, 4);
vec.erase(itr1);