String * arr filling with data, I sent a common variable instead of an array.

Question

0.00/5 (No votes)

See more:

C++

<pre>//Main function void printBythePrice(const HousingRegister &house){ float max; string *arr = new string[house.getnrOfHouses()]; cout << "Enter the price"; cin >> max; house.printBythePrice(arr, max); for (int i = 0; i < house.getnrOfHouses(); i++) { cout << arr[i]; } delete[] arr; } //handler Functinen void HousingRegister::printBythePrice(string *arr, float max)const { int index = 0; for (int i = 0; i <nrOfHouses; i++) { if (housing[i]->getRent() >= max) { arr[index] = housing[i]->toString(); index++; } } }

What I have tried:

I have trie to fix this print code but, i have a problem with the array.
function expects a string * arr filling with data, but you submit a common variable instead of an Array.

How can i fix it?

Posted 27-May-16 0:16am

Member 12549902

Updated 27-May-16 2:19am

v2

Add a Solution

Comments

Member 12549902 27-May-16 6:21am

Anyone who knows what i am doing wrong?

CPallini 27-May-16 6:29am

It just looks you are passing an array of empty strings to printBythePrice method (that is I see NO syntax errors)

Member 12549902 27-May-16 6:32am

Thank you for the answer, How can can i fix it? Can you please, give me an exempel?

CPallini 27-May-16 6:45am

What do you want to fix? I repeat: there isn't a syntax error in the method call (there is just a logical one: you are passing empty strings).
If you don't want to pass empty string then, well, assign them.

Member 12549902 27-May-16 6:51am

Thank you again for the asnwer:
Am i doing wright this time?
I am sorry i am a biginer on the programing..

void printBythePrice(const HousingRegister &house){

float max;
string arr[100];

cout << "Enter the price";
cin >> max;

house.printBythePrice(arr, max);

for (int i = 0; i < house.getnrOfHouses(); i++)
{
cout << arr[i];
}
}

CPallini 27-May-16 6:57am

You never assign a value to any arr[i], so all the 100 array items hold empty strings.

Member 12549902 27-May-16 7:01am

Do you meant like this?
string arr[100]={};

If i am doing wrong again.. can you please sent me a code exempel how you think?

As i said before i am biginer and i want to learn as much as posible.
I have 3 days tring to fix this but i cant fix it.

CPallini 27-May-16 7:22am

No, such code again initialize the arr items with empty strings.
the following code, you know, would set the array item i to a not-empty string:
arr[i] = "foo";

However I misread your code. Now I see your printBythePrice method is intended to fill (at least some items) of arr. It looks correct. Why are you complaining? are you getting compilation errors? Are you getting wrong output? Please give us some details.

Member 12549902 27-May-16 7:52am

First mistake: mismatches in arrays.

second mistake:

function expects a string * arr filling with data, but you submit a common variable instead of an array.

Member 12549902 27-May-16 7:54am

The function works great but i still got this coments i sent it to you..

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

KarstenK · Accepted Answer · 2016-05-27T00:59:00

CPallini seems to be right: your string pointer isnt an array per se. May it is only a string and you access its chars as substring. Some reading about arrays.

Allocate an string array for the use in your code like that:

C++

string array[COUNT];

Tip: use a debugger and make some output to see what

CPallini · Accepted Answer · 2016-05-27T02:19:00

Your code should work.
And, at least, it works in the fake scenario I created to make it run

C++

 #include <iostream>
 #include <vector>
 using namespace std;

class Housing
{
  float rent;
  string name;
public:
  Housing(string name, float rent):rent(rent), name(name){}
  int getRent(){return rent;}
  string toString(){return name;}
};

class HousingRegister
{
  int nrOfHouses;
  vector<Housing * > housing;

public:
  HousingRegister(int houses):nrOfHouses(houses)
  {
    for ( int n=0; n<houses; ++n)
    {
      string name = "foo";
      name.append( 1, (char)('0' + n));
      float rent = 1000.0f * (n+1);
      housing.push_back( new Housing( name, rent ));
    }
  }
  ~ HousingRegister()
  {
    for (size_t n=0; n<housing.size(); ++n)
      delete housing[n];
  }

  void printBythePrice(string *arr, float max) const;
  int getnrOfHouses() const { return nrOfHouses; };

};
void printBythePrice(const HousingRegister &house){

  float max;
  string *arr = new string[house.getnrOfHouses()];
  cout << "Enter the price";
  cin >> max;

  house.printBythePrice(arr, max);

  for (int i = 0; i < house.getnrOfHouses(); i++)

  {
    cout << arr[i];
  }
  delete[] arr;
}



//handler Functinen
void HousingRegister::printBythePrice(string *arr, float max)const {

  int index = 0;

  for (int i = 0; i <nrOfHouses; i++)

  {
    if (housing[i]->getRent() >= max)

    {
                arr[index] = housing[i]->toString();

      index++;
    }
  }
}

int main()
{
  HousingRegister hr(5);

  printBythePrice(hr);
}

String * arr filling with data, I sent a common variable instead of an array.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0