I get multiple records from database using linq and I'm using foreach loop to get each record and added it to a list

Question

5.00/5 (2 votes)

See more:

I get multiple records from database using linq and i'm using foreach loop to get each record and added it to a list

but my problem is list retrieves only last record , how can i get multiple records to the list please help me out

What I have tried:

C#

public List<getsal> GetEmployeMotnhlySalary(decimal Perdaysalary, string sDesignation)
    {
        getsal obj = new getsal();
       
        try
        {

            var EmployeSalarylist = t.Tbl_ResourceTimeSheet.Select(x => new { x.WorkOrderNO, x.Designation, x.ResourceName, x.ResourceID, x.EmployeeID, x.AttendencePeriod, x.NumberofDaysWorked, x.NumberofDaysInMonth, x.Remarks, x.Month, x.Year }).Where(x => x.WorkOrderNO == ddlWorkOrder.Text && x.Month == DLMonth.Text && x.Year == DLYear.Text && x.Designation == sDesignation).ToList();

            
            foreach (var item in EmployeSalarylist)
            {
                
                    //getsal obj = new getsal();
                    obj.OrderNO = item.WorkOrderNO;
                    obj.Name = item.ResourceName;

                    obj.EmpID = item.EmployeeID;
                    obj.AttendedDays = item.NumberofDaysWorked;
                    obj.WorkingDays = item.NumberofDaysInMonth;
                    obj.Remarks = item.Remarks;
                    decimal DEBITAMT = Math.Round((Convert.ToDecimal(item.NumberofDaysWorked) * Perdaysalary), 0);

                    //obj.Month = item.Month;
                    //obj.Year = item.Year;
                    obj.AttendencePeriod = item.AttendencePeriod;
                    obj.Renumeration = TxtSalary.Text;
                    obj.ActualRenumeration = DEBITAMT;
                    obj.EPF = Math.Round(((DEBITAMT * Convert.ToDecimal(txtEmployershareEPF.Text)) / 100), 0);
                    if ((txtEmployershareESI.Text).Trim() != "0")
                    {
                        obj.ESI = Math.Round(((DEBITAMT * (Convert.ToDecimal(txtEmployershareESI.Text))) / 100), 0);
                    }
                    obj.AgencyCommision = Math.Round(((DEBITAMT * Convert.ToDecimal(txtAgencyCommission.Text)) / 100), 0);

                    decimal WithTax = (DEBITAMT + obj.EPF + obj.ESI + obj.AgencyCommision);
                    obj.SubTotal = WithTax;
                    obj.ServiceTax = Math.Round(((WithTax * Convert.ToDecimal(txtServiceTAX.Text)) / 100), 0);
                    obj.Sbc = Math.Round(((WithTax * Convert.ToDecimal(TxtSbc.Text)) / 100), 0);
                    obj.Total = Math.Round((WithTax + obj.ServiceTax + obj.Sbc), 0);
                    li.Add(obj);

            }

        }
        catch (Exception ex)
        {

        }

        return li;

    }

Posted 20-May-16 2:47am

Member 123CC

Updated 6-Apr-21 0:44am

Garth J Lancaster

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2016-05-20T03:00:00

try this, check the inline comments

C#

  public List GetEmployeMotnhlySalary(decimal Perdaysalary, string sDesignation)
{
getsal obj = new getsal();  // remove this line
 
{

var EmployeSalarylist = t.Tbl_ResourceTimeSheet.Select(x => new { x.WorkOrderNO, x.Designation, x.ResourceName, x.ResourceID, x.EmployeeID, x.AttendencePeriod, x.NumberofDaysWorked, x.NumberofDaysInMonth, x.Remarks, x.Month, x.Year }).Where(x => x.WorkOrderNO == ddlWorkOrder.Text && x.Month == DLMonth.Text && x.Year == DLYear.Text && x.Designation == sDesignation).ToList();


foreach (var item in EmployeSalarylist)
{

getsal obj = new getsal();  // uncomment this line
obj.OrderNO = item.WorkOrderNO;

Since getsal is a class which is of reference type and the instance is created once globally outside the loop, so in each iteration of the loop you are just replacing the old values with the new value, at the end of the loop, the last item will be present in all the items of the list..