Commandtext property has not been initialized

Question

4.00/5 (1 vote)

See more:

C#

ListBox ddlcity = new ListBox();
                ddlcity.ID = "city" + i;
                ddlcity.SelectionMode = ListSelectionMode.Multiple;
                string sql = "";
                if (radio.SelectedValue == "0")
                {
                    sql = "select citynew.cityid,citynew.cityname from citynew left join state on citynew.stateid=state.stateid left join country on state.countryid=country.countryid where country.countryname='india'";
                }
                else if (radio.SelectedValue == "1")
                {
                    sql = "select citynew.cityid,citynew.cityname from citynew left join state on citynew.stateid=state.stateid left join country on state.countryid=country.countryid where country.countryname!='india'";
                }
                SqlCommand cmd = new SqlCommand(sql, conn);
                SqlDataAdapter da = new SqlDataAdapter(cmd);
                DataSet ds = new DataSet();
                da.Fill(ds);

                ddlcity.DataSource = ds;

                ddlcity.DataTextField = "cityname";
                ddlcity.DataValueField = "cityid";
                ddlcity.DataBind();
                ddlcity.Items.Insert(0, new ListItem("--Select--", "0"));


                plc.Controls.Add(ddlcity);

The sql query will display the value bt while inserting the data i got the error
CommandText property has not been initialized

What I have tried:

The sql query will display the value bt while inserting the data i got the error
CommandText property has not been initialized

Posted 2-May-16 1:00am

Member 12497501

Updated 2-May-16 2:24am

Herman<T>.Instance

v2

Add a Solution

Comments

Herman<T>.Instance 2-May-16 7:07am

what is the value of radio.SelectedValue ?
If it is > 1 than: the string sql = "";

Karthik_Mahalingam 2-May-16 8:15am

post the insert code.

Member 12497501 2-May-16 8:29am

protected void AddControls()
{
conn = new SqlConnection(ConfigurationManager.ConnectionStrings["dbconnect"].ConnectionString);
conn.Open();
int val = Columns;
for (int i = 0; i < val; i++)
{

ListBox ddlcity = new ListBox();
ddlcity.ID = "city" + i;
ddlcity.SelectionMode = ListSelectionMode.Multiple;
string sql = "";
if (radio.selectedvalue=="0")
{

sql = "select citynew.cityid,citynew.cityname from citynew left join state on citynew.stateid=state.stateid left join country on state.countryid=country.countryid where country.countryname='india'";
}
else if (radio.selectedvalue=="1")
{

sql = "select citynew.cityid,citynew.cityname from citynew left join state on citynew.stateid=state.stateid left join country on state.countryid=country.countryid where country.countryname!='india'";
}
else
{

throw new Exception(string.Format("Selected value is undefined:"));
}

SqlCommand cmd = new SqlCommand(sql, conn);
SqlDataAdapter da = new SqlDataAdapter(cmd);
DataSet ds = new DataSet();
da.Fill(ds);

ddlcity.DataSource = ds;

ddlcity.DataTextField = "cityname";
ddlcity.DataValueField = "cityid";
ddlcity.DataBind();
ddlcity.Items.Insert(0, new ListItem("--Select--", "0"));

plc.Controls.Add(ddlcity);
}
conn.Close();
ViewState["controlsadded"] = true;
}

protected override void LoadViewState(object savedState)
{
base.LoadViewState(savedState);
if (ViewState["controsladded"] == null)
{
AddControls();
}
}
protected void btnsubmit_Click(object sender, EventArgs e)
{
ListBox newcity = new ListBox();

int val = Columns;
for (int i = 0; i < val; i++)
{

newcity = (ListBox)(plc.FindControl("city" + i));
foreach (ListItem li in newcity.Items)
{
if (li.Selected == true)
{
Response.Write(li.Text);
}
}
}
}

}
}

this is my asp code
<asp:RadioButtonList ID="radio" runat="server">
<asp:ListItem Value="0">domestic
<asp:ListItem Value="1">international

<asp:TextBox ID="txtdays" runat="server" CssClass="form-control" OnTextChanged="add_onclick" AutoPostBack="true">
<asp:Panel ID="plc" runat="server">

<asp:Button ID="btnsubmit" runat="server" Text="btnsubmit_onclick"
onclick="btnsubmit_Click" />

Karthik_Mahalingam 2-May-16 8:36am

in which line you are getting the error?
i have posted the solution, check if it helps.
once again i am not seeing any code for insert data to sql

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

George Jonsson · Answer 1 · 2016-05-02T01:17:00

It is bad practice to use

C#

if ()
else if ()

without a final else statement even if you think your variable will never have an unexpected value.

What will happen if your defined statements are not met is that the program runs through to the statement after the last else if.

Either add an else statement that takes care of this undefined case or change to a switch statement with a default statement.

C#

if (radio.SelectedValue == "0")
{
    sql = ...
}
else if (radio.SelectedValue == "1")
{
    sql = ...
}
else
{
    throw new Exception(string.Format("Selected value is undefined: {0}.", radio.SelectedValue));
}

or

C#

switch (radio.SelectedValue)
{
    case 1: sql = ...; break;
    case 2: sql = ...; break;
    default: throw new Exception(string.Format("Selected value is undefined: {0}.", radio.SelectedValue));
}

Karthik_Mahalingam · Answer 2 · 2016-05-02T02:24:00

Ensure that the SqlCommandText is not null/Empty before executing an SqlCommand
If you selected value is greater than 1, the SqlCommandText value will be empty which results in Exception.

Validate it before usage

C#

if (sql != "")  // Validate for non empty
            {

                SqlCommand cmd = new SqlCommand(sql, conn);
                SqlDataAdapter da = new SqlDataAdapter(cmd);
                DataSet ds = new DataSet();
                da.Fill(ds);

                ddlcity.DataSource = ds;

                ddlcity.DataTextField = "cityname";
                ddlcity.DataValueField = "cityid";
                ddlcity.DataBind();
                ddlcity.Items.Insert(0, new ListItem("--Select--", "0"));
            }

Commandtext property has not been initialized

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0