Syntax error in UPDATE statement. Visual basic 2010

Question

0.00/5 (No votes)

See more:

I this error:
"Syntax error in UPDATE statement."

My code is:

Private Sub Button3_Click(sender As System.Object, e As System.EventArgs) Handles Button3.Click
       con.Open()
       Dim q As String = "UPDATE Table1 SET " &
           "FirstName='" & Me.txtFName.Text &
           "',SecondName='" & Me.txtSName.Text &
           "',SureName='" & Me.txtTName.Text &
           "',SocialNumber=" & Me.txtID.Text &
           ",Age=" & Me.txtAge.Text & " " &
           ",YearofBirth=" & Me.txtYear.Text & " " &
           ",Level=" & Me.txtLevel.Text & " " &
           "WHERE ID=" & Me.TextBox1.Text


       Dim cmd As New OleDb.OleDbCommand(q, con)
       cmd.ExecuteNonQuery()
       GetInfo()
       Me.Close()
       con.Close()
   End Sub

btw I am using Visual Basic 2010 and Access 2016 for database
Thank you!

What I have tried:

I haven't tried anything yet since I am just a beginner.

Posted 20-Apr-16 8:21am

Member 12473898

Updated 20-Apr-16 9:54am

Add a Solution

Comments

Richard Deeming 20-Apr-16 15:11pm

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Answer 1 · 2016-04-20T09:54:00

Solution 2

As Richard pointed out, don't do it this way. Not only does it lead to syntax issues but it is very easy to hack your db when you write code this way. Instead do like this:

VB

Dim q As String = "UPDATE Table1 SET " &
           "FirstName=@FirstName" &
           "',SecondName=@SecondName" & ...
           "WHERE ID=@ID" 
...
cmd.Parameters.AddWithValue("@FirstName", txtFirstName.Text)
cmd.Parameters.AddWithValue("@SecondName", txtSecondName.Text)
...
cmd.Parameters.AddWithValue("@ID", txtID.Text)

Posted 20-Apr-16 9:54am

ZurdoDev

Comments

Richard Deeming 20-Apr-16 16:55pm

Except that OleDb doesn't support named parameters, so you'd need to use ? as the placeholder and add the parameters in the right order.

ZurdoDev 20-Apr-16 20:06pm

Good catch.

ZurdoDev 20-Apr-16 20:12pm

Interesting, some sites say named parameters are OK, https://blogs.msdn.microsoft.com/wriju/2008/01/24/ado-net-oledbcommand-parameterized-query-sequence-rule/

and others say they are not, https://msdn.microsoft.com/en-us/library/system.data.oledb.oledbcommand.parameters(v=vs.110).aspx

But the order is definitely important.