How do I solve this prolem

Question

0.00/5 (No votes)

See more:

When i try to execute the following code, i get an error message saying data type mismatch in criteria expression. I am using MS Access database

What I have tried:

Here's the code

C#

private void btnSave_Click(object sender, EventArgs e)

        {
            try
            {
                conn.Open();

                OleDbCommand cmd = new OleDbCommand();
                cmd.Connection = conn;
                cmd.CommandText = "insert into master (MOW,GK,CLASS,MAKE,MODEL,YOP,MNTH,PRICE,ENGINE_NUMBER,CHASSIS_NUMBER,CC,HP,LOCATION,LOGBOOK,MERCHANT,REPLACED_ENGINE_NUMBER,REMARKS,COUNTY) values('" + txtMOW.Text + "','" + txtGK.Text + "','" + txtCLASS.Text + "','" + txtMAKE.Text + "','" + txtMODEL.Text+ "','" + txtYOP.Text + "','" + txtMNTH.Text + "','" + txtPRICE.Text + "','" + txtENGINENUMBER.Text + "','" + txtCHASSISNUMBER.Text + "','" + txtCC.Text + "','" + txtHP.Text + "','" + txtLOCATION.Text + "','" + txtLOGBOOK.Text + "','" + txtMERCHANT.Text + "','" + txtRENGINENUMBER.Text + "','" + txtREMARKS.Text + "','" + txtCOUNTY.Text + "')";

                cmd.ExecuteNonQuery();
                MessageBox.Show("Data Saved !!!!");
                conn.Close();
            }
            catch (Exception ex)
            {
                MessageBox.Show("Error" + ex.Message);
            }

        }

Posted 17-Mar-16 23:55pm

Member 12401110

Updated 18-Mar-16 0:11am

Michael_Davies

v2

Add a Solution

Comments

Michael_Davies 18-Mar-16 6:05am

Hi, without knowing what is in the text boxes and what the schema is for the table it is difficult to help.

Recommend you do not construct an SQL string, use parameters instead and you will get to see the actual field in error as you add the parameter values and it fails.

If you must construct an SQL string, use the debugger to look at it's contents before you execute it which might help spot the problem.

[no name] 18-Mar-16 6:07am

This is pretty much straight forward. Just cross datatype of all the columns which are using in your query. Because you are passing value as character/string format, if some column is integer then will throw exception(what is you are getting now).

Sarrrva 18-Mar-16 6:13am

Can you provide that table schema ?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2016-03-18T00:09:00

Don't do it like that.
Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.
The chances are that your problem will disappear at the same time...
For example:

C#

using (OleDbCommand cmd = new OleDbCommand("INSERT INTO master (Col1, Col2) VALUES (?,?)", conn))
   {
   cmd.Parameters.AddWithValue("@COL1", valueForColumn1);
   cmd.Parameters.AddWithValue("@COL2", valueForColumm2);
   cmd.ExecuteNonQuery();
   }