Write a program which reads 5 integer elements, stores them, reverse them all and store in a separate array. Print both arrays at the end.

Question

1.00/5 (5 votes)

See more:

C++

#include <iostream>
using namespace std;
main(){
	int i,j;
	int arr[i];
	int new_arr[i];
	int number,store=0;
	for(i=0;i<5;i++){
		cout<<"enter the 5-digit element of array : ";
		cin>>number;
		arr[i]=number;
		for(j=0;j<5;j++){
			store=store*10+(number%10);
			number=number/10;
		}
		new_arr[i]=store;
	}
	cout<<"the 5 digit element array is : "<<arr[0]<<" "<<arr[1]<<" "<<arr[2]<<" "<<arr[3]<<" "<<arr[4]<<endl;
	cout<<"the 5 digit element reverse order array is : "<<new_arr[0]<<" "<<new_arr[1]<<" "<<new_arr[2]<<" "<<new_arr[3]<<" "<<new_arr[4]<<endl;
	return 0;
}

Posted 17-Dec-15 2:24am

zeib

Updated 17-Dec-15 2:51am

v3

Add a Solution

Comments

PIEBALDconsult 17-Dec-15 8:31am

Did you have a question?

zeib 17-Dec-15 8:37am

its not working the above code. every time i run it it gives two or three true values and the rest garbage values

zeib 17-Dec-15 8:37am

what's the error in above code???

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Answer 1 · 2015-12-17T02:50:00

You are passing the uninitialised variable i to specify the array sizes:

int i,j;
int arr[i];
int new_arr[i];

As a result, you don't know how large your arrays are actually. The compiler may initialise i with zero so that your arrays did not really exist and you will get random values from the stack when reading items out.

To avoid such mistakes you should set the compiler warning level to maximum and fix your code until you got no warnings.

[EDIT/UPDATE]
In your case I would define a size:

const int max_items = 5;
int arr[max_items];
int new_arr[max_items];
// ...
for (i = 0; i < max_items; i++)
// ...

[EDIT/UPDATE 2]
Once the above has been fixed, you should also reset store before the inner loop. Otherwise the value is cumulated over all five input values:

// Reset store before calculation 
store = 0;
for(j=0;j<5;j++){