Index out of range exception.

Question

0.00/5 (No votes)

See more:

I have one form in which i run query which gives me data of 7 rows but while i running loop to print 7 rows in dgv . only one row printed and when trying to print next row above error shows at insertion statement of dgv.

here is my code for reference,

C#

private void btnsearch_Click(object sender, EventArgs e)
{
   try
   {
     DateTime frmdate = Convert.ToDateTime(dtpfrom.Text);
     DateTime todate = Convert.ToDateTime(dtpto.Text);
     string datetimefrm = frmdate.ToString("yyyy-MM-dd 00:00:00.000");
     string datetimeto = todate.ToString("yyyy-MM-dd 00:00:00.000");

    if (ckaprov.Checked == true)
    {
       cmd = new SqlCommand();
       cmd.CommandType = CommandType.StoredProcedure;
       cmd.CommandText = "Proc_GetIndentBetweenDate";
       cmd.Parameters.Add(new SqlParameter("fromDate", datetimefrm));
       cmd.Parameters.Add(new SqlParameter("@toDate", datetimeto));
       cmd.Connection = con;
       table = new DataTable();
       adapter = new SqlDataAdapter(cmd);
       adapter.Fill(table);
       int count = table.Columns.Count;

    if (table.Rows.Count > 0)
    {
       foreach (DataRow rw in table.Rows)
       {
         string no = rw["Indent No"].ToString();
         string date = rw["Indent Date"].ToString();
         string frm = rw["From Store"].ToString();
         string to = rw["To Store"].ToString();
         string status = rw["Indent Status"].ToString();
         string emergency = rw["Emergency Indent"].ToString();

        for (int i = 0; i <= table.Rows.Count - 1; i++)
        {
           dataGridView1.Rows[i].Cells[1].Value = no;
           dataGridView1.Rows[i].Cells[2].Value = date;
           dataGridView1.Rows[i].Cells[3].Value = frm;
           dataGridView1.Rows[i].Cells[4].Value = to;
           dataGridView1.Rows[i].Cells[5].Value = status;
           dataGridView1.Rows[i].Cells[6].Value = emergency;
           dataGridView1.Rows[i].Cells[7].Value = "Send";
        }
         // dataGridView1.Rows.Add();
    }
  }
else { MessageBox.Show("No indents present between these dates."); }
}
else
{
MessageBox.Show("No open indents found , Please check Approved.");
}
}
catch { }
}

Posted 5-Dec-15 0:46am

Member 11543226

Updated 5-Dec-15 0:49am

v2

Add a Solution

Comments

deepankarbhatnagar 7-Dec-15 1:03am

Please check the rowcount of your table.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2015-12-05T00:56:00

It's not the rows.
It's the cells.

C# array indexes are zero based, so it's likely that these:

C#

for (int i = 0; i <= table.Rows.Count - 1; i++)
{
   dataGridView1.Rows[i].Cells[1].Value = no;
   dataGridView1.Rows[i].Cells[2].Value = date;
   dataGridView1.Rows[i].Cells[3].Value = frm;
   dataGridView1.Rows[i].Cells[4].Value = to;
   dataGridView1.Rows[i].Cells[5].Value = status;
   dataGridView1.Rows[i].Cells[6].Value = emergency;
   dataGridView1.Rows[i].Cells[7].Value = "Send";
}

Should be these:

C#

for (int i = 0; i <= table.Rows.Count - 1; i++)
{
   dataGridView1.Rows[i].Cells[0].Value = no;
   dataGridView1.Rows[i].Cells[1].Value = date;
   dataGridView1.Rows[i].Cells[2].Value = frm;
   dataGridView1.Rows[i].Cells[3].Value = to;
   dataGridView1.Rows[i].Cells[4].Value = status;
   dataGridView1.Rows[i].Cells[5].Value = emergency;
   dataGridView1.Rows[i].Cells[6].Value = "Send";
}

[edit]
Alternatively, it could be that you just don't have enough rows in your DGV - you would have to use the Rows.Add method instead of assuming a row exists.
[/edit]

George Jonsson · Answer 2 · 2015-12-06T16:19:00

Why not use the DataTable as the DataSource of the DataGridView?
Either directly or via a BindingSource.
It will make your code a bit simpler.

C#

private void btnsearch_Click(object sender, EventArgs e)
{
    try
    {
        DateTime frmdate = Convert.ToDateTime(dtpfrom.Text);
        DateTime todate = Convert.ToDateTime(dtpto.Text);
        string datetimefrm = frmdate.ToString("yyyy-MM-dd 00:00:00.000");
        string datetimeto = todate.ToString("yyyy-MM-dd 00:00:00.000");
        
        if (ckaprov.Checked == true)
        {
            cmd = new SqlCommand();
            cmd.CommandType = CommandType.StoredProcedure;
            cmd.CommandText = "Proc_GetIndentBetweenDate";
            cmd.Parameters.Add(new SqlParameter("fromDate", datetimefrm));
            cmd.Parameters.Add(new SqlParameter("@toDate", datetimeto));
            cmd.Connection = con;
            table = new DataTable();
            adapter = new SqlDataAdapter(cmd);
            adapter.Fill(table);

            dataGridView1.DataSource = table.DefaultView;
        }
        else
        {
            MessageBox.Show("No open indents found , Please check Approved.");
        }
    }
    catch (Exception ex)
    {
        MessageBox.Show(ex.ToString());
    }
}

Also, hiding an exception is usually a bad idea, especially during debugging.

Index out of range exception.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0