vb6 sql command error

Question

1.00/5 (1 vote)

See more:

What Wrong with this code..

VB

Private Sub useradd_Click()
Dim cmd as New ADODB.Command

cmd.ActiveConnection = con
cmd.CommandText = "insert into userlist(emp_id,first_name,last_name,username,password,usertype) values(" & empid.Text & ",'" & fn.Text & "','" & ln.Text & "','" & un.Text & "','" & pwd.Text & "','" & usertype.Text & "');"
'On Error GoTo errlbl
cmd.Execute
MsgBox "User Created Successfully", vbInformation
Exit Sub
'errlbl:
'MsgBox "Error : " & Err.Number & Err.Description, vbCritical
End Sub

Error Shown INSERT INTO Syntax error

Posted 25-Oct-15 22:19pm

Naveen Roy

Add a Solution

Comments

F-ES Sitecore 26-Oct-15 4:58am

The code will fail if any of your text boxes have an apostrophe, or the empid is not numeric. Use parameterised queries instead of building the SQL like that, as your code is prone to sql injection attacks.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2015-10-25T22:32:00

Solution 1

I would grab the cmd.CommandText value at runtime (using the debugger) and then use such a value to query directly the database engine (in order to better understand what the error is).

Posted 25-Oct-15 22:32pm

CPallini