How to make use of Static variable constant over a each WCF service call?

Question

0.00/5 (No votes)

See more:

Here is Service Call,

C#

public void CalculateTimeTake(string isoCountryCode)
{
    try
    {
        DateTime startTime = DateTime.Now;
        TimeCalculator.BuildMessage("Service Started", true, startTime);
        //Some Service based Logic
        TimeCalculator.BuildMessage("Service Ended", false, startTime);

        TimeCalculator.DisplayMessage(); //To write a string to particular Event source
    }
    catch (Exception exception)
    {
        
    }
}

Here is the logic available in TimeCalculator,

C#

public class TimeCalculator
{
    private static StringBuilder sb = new StringBuilder();

    public static void BuildMessage(string MethodName, bool aboutToCall, DateTime startTime)
    {
        try
        {
            if (aboutToCall)
                sb.Append(("Calling Method: " + MethodName).PadRight(50, ' ') + "---> Time Recorded: " + startTime.ToString("MM/dd/yyyy HH:mm:ss:ffff", CultureInfo.InvariantCulture) + "; \n");
            else
                sb.Append(("Finished Method: " + MethodName).PadRight(50, ' ') + "---> Time Recorded: " <pre lang="c#">+ DateTime.Now.ToString("MM/dd/yyyy HH:mm:ss:ffff", CultureInfo.InvariantCulture) + ", Total time taken: " + string.Format("{0:n}", ((DateTime.Now - startTime).TotalMilliseconds).ToString()) + " ms ; \n");
        }
        catch (Exception ex)
        {
            Logger.Write("Exception Occured in Time Calculation.\nExceptionDetails:\n" + ex.ToString(), Util.Logging.LogLevel.Debug);
        }
    }

    public static void DisplayMessage()
    {
        try
        {
            Logger.Write(sb.ToString(), Util.Logging.LogLevel.Debug);
            sb = new StringBuilder();
        }
        catch (Exception ex)
        {
            Logger.Write(ex.ToString(), Util.Logging.LogLevel.Warning);
            sb = new StringBuilder();
        }
    }

The problem here is,

Suppose the
first service call is started at 12.10 AM, and has finished at 12.13 AM.
Second service call started at 12.11 AM, and has finished at 12.12 AM.

The string text of second call is overriding the first call string :(
I hope its related to the Static objects used, But can any one please help me how to rectify?

Posted 15-Oct-15 23:38pm

Ravikumar Chunduri

Updated 15-Oct-15 23:49pm

Tomas Takac

v3

Add a Solution

Comments

Tomas Takac 16-Oct-15 5:51am

Why don't you write directly to the log? Why to use the string builder at all?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Answer 1 · 2015-10-15T23:53:00

There is only a single instance of static variables across the app domain so all calls see the same string builder. You mentioned services but you haven't really explained how this code is called. If you are looking to time how long a call takes then just don't use static variables....create an instance of StringBuilder in your Calculate method and pass that to the BuildMessage and DisplayMessage methods so that they all access the same instance.

C#

public void CalculateTimeTake(string isoCountryCode)
        {
            try
            {
                StringBuild sb = new StringBuilder();
                DateTime startTime = DateTime.Now;
                TimeCalculator.BuildMessage(sb, "Service Started", true, startTime);
                //Some Service based Logic
                TimeCalculator.BuildMessage(sb, "Service Ended", false, startTime);

                TimeCalculator.DisplayMessage(sb); //To write a string to particular Event source
            }
            catch (Exception exception)
            {

            }

Update the other methods to use the StringBuilder you pass in rather than the static version.