Threading-Having difficulty. What am I doing wrong?

Question

0.00/5 (No votes)

See more:

I've created a thread (or I'm trying to) which will autosave every so many minutes. I've added a timer (timer1). Whenever I click the button to start the thread, the program doesn't autosave as instructed. So I'm reaching out for help. Here's the code:

Note: I've added this code at the top:

C#

using System.Threading;

I created two threads (t1 & t2) to see if it would make a difference. Maybe I only need one thread to refer to.

CSS

public partial class frmFindAndReplace : Form
    {
        Thread t1;  //I added the two threads so they can be accessed in events
        Thread t2;  //eg, the FormClosing event

C#

private void timer1_Tick(object sender, EventArgs e)
{
    progressBar1.Increment(1);
    lblUpdate.Visible = false;
    lblSaving.Visible = true;
}
private void AutoSave()
{
    timer1.Start();

    if (SaveDoc.FileName != "")
    {
        CreateWordDocument(FilePath, SaveDoc.FileName, pathImage);
        MessageBox.Show("Updated");
        return;
    }
    else
    {
        if (SaveDoc.ShowDialog() == DialogResult.OK)
        {
            CreateWordDocument(FilePath, SaveDoc.FileName, pathImage);
            MessageBox.Show("New Save");
            return;
        }
    }
    lblSaving.Visible = false;
    lblUpdate.Visible = true;
}

Once the Save As button has been clicked, the AutoSave method will begin.

C#

private void saveAsToolStripMenuItem_Click(object sender, EventArgs e)
        {
            t1 = new Thread(AutoSave);           
        }

Same for the Save button.

C#

private void saveToolStripMenuItem_Click(object sender, EventArgs e)
        {
            t2 = new Thread(AutoSave);            
        }

Also having a problem with the FormClosing event. I receive an error everytime I run the program.

C#

private void frmFindAndReplace_FormClosing(object sender, FormClosingEventArgs e)
        {
            if (t1.IsAlive)  
            { t1.Abort(); } //t1.Abort() closes the t1 thread upon exit.

            if (t2.IsAlive)
            { t2.Abort(); } //t2.Abort() closes the t2 thread upon exit.
        }

Posted 26-Sep-15 2:51am

Member 11909035

Updated 26-Sep-15 2:56am

v5

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2015-09-26T04:22:00

Um.
If you want to autosave every five minutes, I'd do it rather more simply.
Set up a Thread and start it.

C#

            private Thread saver;
...
            saver = new Thread(new ThreadStart(SaveRegularly));
            saver.Start();

The thread method soes teh save:

C#

private bool stopAndDie = false;
private void SaveRegularly()
    {
    DateTime saveDueAt = DateTime.Now.AddMinutes(5);
    do
        {
        Thread.Sleep(1000);
        if (DateTime.Now >= saveDueAt)
            {
            // Do your save
            ...
            saveDueAt = DateTime.Now.AddMinutes(5);
            }
        } while (!stopAndDie);
    }

You also handle the form closing event, and set stopAndDie to true, then use Thread.Join to wait for it to exit:

C#

stopAndDie = true;
saver.Join(2000);